From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34904)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cminyard@mvista.com>) id 1b0qdv-0001P6-8B
	for qemu-devel@nongnu.org; Thu, 12 May 2016 09:27:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cminyard@mvista.com>) id 1b0qdr-0001zB-Ue
	for qemu-devel@nongnu.org; Thu, 12 May 2016 09:27:07 -0400
Received: from mail-oi0-x233.google.com ([2607:f8b0:4003:c06::233]:36434)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cminyard@mvista.com>) id 1b0qdr-0001yx-PV
	for qemu-devel@nongnu.org; Thu, 12 May 2016 09:27:03 -0400
Received: by mail-oi0-x233.google.com with SMTP id x201so119230994oif.3
	for <qemu-devel@nongnu.org>; Thu, 12 May 2016 06:27:03 -0700 (PDT)
References: <1462995966-1184-1-git-send-email-minyard@acm.org>
	<1462995966-1184-6-git-send-email-minyard@acm.org>
	<20160512101937-mutt-send-email-mst@redhat.com>
From: Corey Minyard <cminyard@mvista.com>
Message-ID: <573484A1.9000105@mvista.com>
Date: Thu, 12 May 2016 08:26:57 -0500
MIME-Version: 1.0
In-Reply-To: <20160512101937-mutt-send-email-mst@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 5/7] acpi: Add I2c serial bus CRS handling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, minyard@acm.org
Cc: Igor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

On 05/12/2016 02:30 AM, Michael S. Tsirkin wrote:

Thanks for the comments, all fixed.

>>   /**
>>    * init_aml_allocator:
>>    *
>> @@ -327,6 +336,8 @@ Aml *aml_qword_memory(AmlDecode dec, AmlMinFixed min_fixed,
>>   Aml *aml_dma(AmlDmaType typ, AmlDmaBusMaster bm, AmlTransferSize sz,
>>                uint8_t channel);
>>   Aml *aml_sleep(uint64_t msec);
>> +Aml *aml_i2c_serial_bus_device(uint8_t flags, uint32_t con_speed,
> Drop these two parameters until they are actually useful.

I'm not sure I follow here.  The address parameter is important, it's 
for the I2C address.  The top 8 bytes are reserved 0, but not the 
bottom.  The resource source parameter tells which I2C bus it's hooked to.

>
>> +                               uint16_t address, const char *resource_source);
>>   
>>   /* Block AML object primitives */
>>   Aml *aml_scope(const char *name_format, ...) GCC_FMT_ATTR(1, 2);
>> -- 
>> 2.7.4