From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0qjZ-0000Ug-JG for qemu-devel@nongnu.org; Thu, 12 May 2016 09:32:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0qjW-0004Ug-9C for qemu-devel@nongnu.org; Thu, 12 May 2016 09:32:57 -0400 Received: from mail-oi0-x233.google.com ([2607:f8b0:4003:c06::233]:35818) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0qjW-0004Uc-57 for qemu-devel@nongnu.org; Thu, 12 May 2016 09:32:54 -0400 Received: by mail-oi0-x233.google.com with SMTP id x19so119299072oix.2 for ; Thu, 12 May 2016 06:32:53 -0700 (PDT) References: <1462995966-1184-1-git-send-email-minyard@acm.org> <1462995966-1184-8-git-send-email-minyard@acm.org> <20160512103501-mutt-send-email-mst@redhat.com> From: Corey Minyard Message-ID: <57348603.6080905@mvista.com> Date: Thu, 12 May 2016 08:32:51 -0500 MIME-Version: 1.0 In-Reply-To: <20160512103501-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 7/7] ipmi: Add ACPI to the SMBus IPMI device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , minyard@acm.org Cc: Igor Mammedov , Paolo Bonzini , qemu-devel@nongnu.org On 05/12/2016 02:36 AM, Michael S. Tsirkin wrote: > On Wed, May 11, 2016 at 02:46:06PM -0500, minyard@acm.org wrote: >> From: Corey Minyard >> >> Signed-off-by: Corey Minyard >> --- >> hw/ipmi/smbus_ipmi.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/hw/ipmi/smbus_ipmi.c b/hw/ipmi/smbus_ipmi.c >> index 4e7203b..3a34aaf 100644 >> --- a/hw/ipmi/smbus_ipmi.c >> +++ b/hw/ipmi/smbus_ipmi.c >> @@ -167,6 +167,7 @@ static void smbus_ipmi_realize(DeviceState *dev, Error **errp) >> sid->fwinfo.base_address = sid->parent.i2c.address; >> sid->fwinfo.memspace = IPMI_MEMSPACE_SMBUS; >> sid->fwinfo.register_spacing = 1; >> + sid->fwinfo.acpi_parent = "\\_SB.PCI0.SMB0"; > I don't think it's a good idea to spread things like PCI0 > outside acpi-build.c. Why do you want to pass in the path > at all? You have to define the namespace for the ASL definition, and you have to give the name in the serial bus definition. However, thinking it through some more, this name needs to come from the I2C device, not just hard-coded here. -corey >> ipmi_add_fwinfo(&sid->fwinfo, errp); >> } >> >> -- >> 2.7.4