From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0twG-0005AM-8b for qemu-devel@nongnu.org; Thu, 12 May 2016 12:58:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0twE-0007qK-Px for qemu-devel@nongnu.org; Thu, 12 May 2016 12:58:16 -0400 References: <1462552005-4887-1-git-send-email-eblake@redhat.com> <1462552005-4887-7-git-send-email-eblake@redhat.com> <57346821.90709@redhat.com> From: Eric Blake Message-ID: <5734B620.6040503@redhat.com> Date: Thu, 12 May 2016 10:58:08 -0600 MIME-Version: 1.0 In-Reply-To: <57346821.90709@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="whLuQlbwJkq0OXhk204JksFGhugQNwPk9" Subject: Re: [Qemu-devel] [PATCH v7 06/19] scsi-disk: Switch to byte-based aio block access List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: kwolf@redhat.com, qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --whLuQlbwJkq0OXhk204JksFGhugQNwPk9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/12/2016 05:25 AM, Paolo Bonzini wrote: >=20 >=20 > On 06/05/2016 18:26, Eric Blake wrote: >> @@ -340,11 +338,12 @@ static void scsi_do_read(SCSIDiskReq *r, int ret= ) >> r->req.aiocb =3D dma_blk_read(s->qdev.conf.blk, r->req.sg, r-= >sector, >> scsi_dma_complete, r); >=20 > This is broken, it should be changed to an offset in the previous patch= =2E >=20 > Please rename the function too, so that it is obvious that you have > changed all callers. >=20 > How was this patch tested? Sadly, my testing was limited to NBD use of the blk_ functions, then compile testing and close audit of all other drivers, to limit the changes to ONLY the blk_ calling conventions. That's why I kept sector alignment in other calls (as you later noticed, that means dma_blk_read() was unchanged in semantics). Yes, there are more cleanups possible, such as altering things to a new dma_blk_pread() with byte semantics, but I'm hoping that it can be done on a per-driver basis by someone more familiar with how to test the changes. I also like the fact that my patches were done at the very beginning of the 2.7 cycle to maximize testing. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --whLuQlbwJkq0OXhk204JksFGhugQNwPk9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXNLYgAAoJEKeha0olJ0NqI6AIAJNOyPfB5Uw5PYIguFGD/CHf I06No7ZBDor1EZICaKoHLlEbMXKUtMNJ/wzHSb/cEv6lorT3RqaeCiSo9LbxBM9M 9HSG+TmL1ANTEk52iP+mIuv9B0C083RYDyhJ3Od67ECco51ZFVY3G3V71v8lmsIP VvDCJwXibS8hBnvZTJdqeXh+bET+5JhsBdWJPmNpBFXL+5k23vVA1fNOMCGeOOmP w9GzAEtf7Pq9JjRGFcj08jaSNE/Rl5YyT+w6fMlNwSS+AwDbTosflX9RELlar2H5 8sEDVDsJUXXIr8mFjsqjdB7KTYaEkbvhq2PpIZ6Jqp9rsziUHWKHqTA/ICJQWVU= =he1w -----END PGP SIGNATURE----- --whLuQlbwJkq0OXhk204JksFGhugQNwPk9--