From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49452) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0x4N-0007B6-9s for qemu-devel@nongnu.org; Thu, 12 May 2016 16:18:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0x4L-0004K6-Pg for qemu-devel@nongnu.org; Thu, 12 May 2016 16:18:51 -0400 References: <1461763231-17598-1-git-send-email-kwolf@redhat.com> <1461763231-17598-6-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <5734E521.8020009@redhat.com> Date: Thu, 12 May 2016 14:18:41 -0600 MIME-Version: 1.0 In-Reply-To: <1461763231-17598-6-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Fv9IlDbP0E6IkshMc85VSsa9oL01rGohW" Subject: Re: [Qemu-devel] [PATCH v2 5/9] block: Remove bdrv_aio_multiwrite() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, jcody@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Fv9IlDbP0E6IkshMc85VSsa9oL01rGohW Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/27/2016 07:20 AM, Kevin Wolf wrote: > Since virtio-blk implements request merging itself these days, the only= > remaining users are test cases for the function. That doesn't make the > function exactly useful any more. >=20 > Signed-off-by: Kevin Wolf > Reviewed-by: Max Reitz > --- > +++ b/tests/qemu-iotests/136 > @@ -248,14 +248,6 @@ sector =3D "%d" > if failed_wr_ops > 0: > highest_offset =3D max(highest_offset, bad_offset + 512) > =20 > - for i in range(wr_merged): > - first =3D i * wr_size * 2 > - second =3D first + wr_size > - ops.append("multiwrite %d %d ; %d %d" % > - (first, wr_size, second, wr_size)) > - > - highest_offset =3D max(highest_offset, wr_merged * wr_size * 2= ) > - Why not delete the wr_merged parameter from do_test_stats()... > # Now perform all operations > for op in ops: > self.vm.hmp_qemu_io("drive0", op) > @@ -309,19 +301,15 @@ sector =3D "%d" > def test_flush(self): > self.do_test_stats(flush_ops =3D 8) > =20 > - def test_merged(self): > - for i in range(5): > - self.do_test_stats(wr_merged =3D i * 3) > - > def test_all(self): > # rd_size, rd_ops, wr_size, wr_ops, flush_ops > # invalid_rd_ops, invalid_wr_ops, > # failed_rd_ops, failed_wr_ops > # wr_merged > - test_values =3D [[512, 1, 512, 1, 1, 4, 7, 5, 2, 1], > - [65536, 1, 2048, 12, 7, 7, 5, 2, 5, 5], > - [32768, 9, 8192, 1, 4, 3, 2, 4, 6, 4], > - [16384, 11, 3584, 16, 9, 8, 6, 7, 3, 4]] > + test_values =3D [[512, 1, 512, 1, 1, 4, 7, 5, 2, 0], as well as remove the # wr_merged comment and the now-useless final member of each test_values[] array entry? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Fv9IlDbP0E6IkshMc85VSsa9oL01rGohW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXNOUiAAoJEKeha0olJ0NqM74H+gI2ctfQcMIMUU4VRDdOCVOP F+2XMm3bZXUZ57VA8BSUJGqkttPXMnt4w+A6vunVKOeQJglVJm0yDasZoz4/a6nv Mb2BE07xYEmKoSH9paro7+u812IgykeEA0LWnxLQdCPf+ZdOEeFUhCVl7x7VKC/a V1qLZqfpgC1IVNMyLSS90MqY9wyEcRLmIDAEgeSoVGZWRBjO5WFnN+xWDxgwFGzg ilVBsmaBRDkAHACUnvypY1wDA3VrabHIYrG6C9DFG+t1xyqWOOnZnobTtWdt5/zO SfCfx/zDRzRl7R/yJJrVco9PV94MGPNXve+/5FPcVJT2jpN1p0nNNJ5PvOB5Ygs= =sr2S -----END PGP SIGNATURE----- --Fv9IlDbP0E6IkshMc85VSsa9oL01rGohW--