From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0yXH-0008LA-T8 for qemu-devel@nongnu.org; Thu, 12 May 2016 17:52:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0yXF-0005mY-K0 for qemu-devel@nongnu.org; Thu, 12 May 2016 17:52:46 -0400 References: <1462677405-4752-1-git-send-email-eblake@redhat.com> <1462677405-4752-5-git-send-email-eblake@redhat.com> <20160512143822.GE4794@noname.redhat.com> <5734A646.3080100@redhat.com> From: Eric Blake Message-ID: <5734FB22.1010502@redhat.com> Date: Thu, 12 May 2016 15:52:34 -0600 MIME-Version: 1.0 In-Reply-To: <5734A646.3080100@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="x88DG4XvqvgVh7qFKiH9i3GweQCFqMenl" Subject: Re: [Qemu-devel] [PATCH v5 4/6] qemu-io: Allow unaligned access by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: kwolf@nongnu.org, qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --x88DG4XvqvgVh7qFKiH9i3GweQCFqMenl Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/12/2016 09:50 AM, Eric Blake wrote: >> This breaks qemu-iotests 136 for raw. It's pretty obvious that this is= a >> test case problem (uses unaligned requests to test error accounting), = so >> I'm not dropping the patch, but please do send a follow-up. >=20 > ...which explains why I missed this failure with ./check -raw. Will > fix, and maybe I should have grepped a bit harder, since it is fairly > obvious: >=20 > tests/qemu-iotests/136: # Two types of invalid operations: > unaligned length and unaligned offset >=20 > I will also check if this needs updating: >=20 > tests/qemu-iotests/109: # qemu-img compare can't handle unaligned > file sizes Turns out the comment was stale, even before my recent patches, but I didn't bother bisecting to find when qemu-img learned to handle unaligned raw images. But see my comments in my other mail on the patch for this file: 'qemu-img compare' doesn't necessarily give the nicest of error messages for unaligned files >=20 > as both of those tests run under -raw but not -qcow2 >=20 >> >> Maybe negative length and offset work as a replacement. Sadly, no, because cvtnum() doesn't like things larger than INT64_MAX, so you can't pass in a negative number. I added a new '-i' flag instead; series now available for review. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --x88DG4XvqvgVh7qFKiH9i3GweQCFqMenl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXNPsjAAoJEKeha0olJ0NqPmYH/1gZwe/xZW0EC+A3FjSfTF2+ c791zHrsUxb6xaVwjL/Fzd6He7ecx1i8UNQ5SDeXBANb/eYL8kFQn+7FZ/MK7vKu /8GazuWkSvKLGhKfv3kpjGL0o3jKA9K8P19a/Hz59kfdaYABhwe+1eJ0iWYrFvtA ixFBg1dRsAfYHPYl2lg24PVIHfaqHQ8zrPc5PBjp0JrDbWqMrGrmKYEXmgR/0wv7 LFQocgqxeMtgBZL8QMFucTnBRfVhFd0+Yky2biqHV94pcsPzHuu3ul3zyRfhjVwk 79LKkq35G2hQSiGhwZza0qw9YmnYbZ2jYku4J6PBApcubjTC0vcazGop/LkEbbQ= =pZth -----END PGP SIGNATURE----- --x88DG4XvqvgVh7qFKiH9i3GweQCFqMenl--