All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Abongwa Amahnui Bonalais" <abongwabonalais@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] "bitbake-prserv-tool: Added quotes to variables to prevent splitting and gobbling"
Date: Wed, 13 Apr 2022 03:50:00 -0700	[thread overview]
Message-ID: <5735.1649847000305548289@lists.openembedded.org> (raw)
In-Reply-To: <8d17cc7d9f13ca534b3f56cb299a1e26da042e18.camel@linuxfoundation.org>

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]

Okay thank you what about Using $(...) notation instead of legacy backticked `...`.
base=`basename $0`, changing it to base=$(basename $0)

Should I commence those changes?
I'm seeing that based om recommendations when I run shellcheck <name of file>

[-- Attachment #2: Type: text/html, Size: 288 bytes --]

  reply	other threads:[~2022-04-13 15:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.4b547764-f1ab-4220-9cb3-e9c4ae848711@emailsignatures365.codetwo.com>
     [not found] ` <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.0d2bd5fa-15cc-4b27-b94e-83614f9e5b38.e4d1c566-c78b-4344-9ede-7a749348d920@emailsignatures365.codetwo.com>
2022-04-13  9:35   ` [PATCH] "bitbake-prserv-tool: Added quotes to variables to prevent splitting and gobbling" Abongwa Bonalais Amahnui
2022-04-13  9:51     ` [OE-core] " Mike Looijmans
2022-04-13 10:10       ` Abongwa Amahnui Bonalais
2022-04-13 10:21       ` [OE-core] " Peter Kjellerstedt
2022-04-13 10:30         ` Abongwa Amahnui Bonalais
2022-04-13 10:34     ` [OE-core] " Richard Purdie
2022-04-13 10:50       ` Abongwa Amahnui Bonalais [this message]
2022-04-13 11:13         ` Richard Purdie
2022-04-13 12:52           ` Abongwa Amahnui Bonalais
2022-04-13 12:55             ` [OE-core] " Richard Purdie
2022-04-13 15:23               ` Abongwa Amahnui Bonalais

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5735.1649847000305548289@lists.openembedded.org \
    --to=abongwabonalais@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.