From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b19Ld-0000s5-Bx for qemu-devel@nongnu.org; Fri, 13 May 2016 05:25:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b19LY-0006iN-84 for qemu-devel@nongnu.org; Fri, 13 May 2016 05:25:28 -0400 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:35071) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b19LX-0006i8-VL for qemu-devel@nongnu.org; Fri, 13 May 2016 05:25:24 -0400 Received: by mail-wm0-x244.google.com with SMTP id e201so2472374wme.2 for ; Fri, 13 May 2016 02:25:23 -0700 (PDT) Sender: Paolo Bonzini References: <1459870344-16773-1-git-send-email-alex.bennee@linaro.org> <1459870344-16773-5-git-send-email-alex.bennee@linaro.org> <572CE0CD.3040004@gmail.com> <57332C6A.1080006@redhat.com> <57333578.4080609@gmail.com> <573337A4.2030101@redhat.com> <5734DA58.8080406@gmail.com> From: Paolo Bonzini Message-ID: <57359D7A.6020805@redhat.com> Date: Fri, 13 May 2016 11:25:14 +0200 MIME-Version: 1.0 In-Reply-To: <5734DA58.8080406@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v2 04/11] tcg: comment on which functions have to be called with tb_lock held List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Fedorov , =?UTF-8?Q?Alex_Benn=c3=a9e?= , mttcg@greensocs.com, fred.konrad@greensocs.com, a.rigo@virtualopensystems.com, cota@braap.org Cc: peter.maydell@linaro.org, Peter Crosthwaite , claudio.fontana@huawei.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, jan.kiszka@siemens.com, =?UTF-8?Q?Andreas_F=c3=a4rber?= , rth@twiddle.net On 12/05/2016 21:32, Sergey Fedorov wrote: >> > >> > As mentioned above, user-mode emulation uses l1_map in linux-user/mmap.c >> > via page_{get,set}_flags, which I guess is why the lock is separate. >> > None of us was involved in the original multi-threaded linux-user work, >> > we're reverse engineering it just like you. :) > While I'm investigating 'tb_lock' and 'mmap_lock' usage I am wondering > why don't put 'l1_map' into 'tcg_ctx'? Yes, that makes sense. Paolo