From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Hans Verkuil <hverkuil@xs4all.nl>, linux-media@vger.kernel.org
Cc: mchehab@osg.samsung.com, david@unsolicited.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] vb2: core: Skip planes array verification if pb is NULL
Date: Fri, 13 May 2016 12:38:26 +0300 [thread overview]
Message-ID: <5735A092.5000209@linux.intel.com> (raw)
In-Reply-To: <573599BF.4050708@xs4all.nl>
Hi Hans,
Hans Verkuil wrote:
> On 05/12/2016 02:14 PM, Sakari Ailus wrote:
>> An earlier patch fixing an input validation issue introduced another
>> issue: vb2_core_dqbuf() is called with pb argument value NULL in some
>> cases, causing a NULL pointer dereference. Fix this by skipping the
>> verification as there's nothing to verify.
>>
>> Signed-off-by: David R <david@unsolicited.net>
>>
>> Use if () instead of ? :; it's nicer that way. Improve the comment in the
>> code as well.
>
> This comment doesn't seem applicable to this patch.
Compared to the original patch. I can sure drop the comment as well,
it's not that important.
>
> Reviewed-by: Hans Verkuil <hans.verkuil@cisco.com>
Thanks!
--
Sakari Ailus
sakari.ailus@linux.intel.com
next prev parent reply other threads:[~2016-05-13 9:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 12:14 [PATCH v2 0/2] videobuf2: Fix kernel memory overwriting Sakari Ailus
2016-05-12 12:14 ` [PATCH v2 1/2] vb2: core: Skip planes array verification if pb is NULL Sakari Ailus
2016-05-13 9:09 ` Hans Verkuil
2016-05-13 9:38 ` Sakari Ailus [this message]
2016-05-12 12:14 ` [PATCH v2 2/2] [media] videobuf2-v4l2: Verify planes array in buffer dequeueing Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5735A092.5000209@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=david@unsolicited.net \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.