All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikolay Borisov <kernel@kyup.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Subject: Stack trace of csum_partial_copy_generic
Date: Fri, 13 May 2016 14:07:47 +0300	[thread overview]
Message-ID: <5735B583.6090500@kyup.com> (raw)

Hello Josh, 

I'd like to ask you whether objtool is supposed to produce a 
warning when arch/x86/lib/csum-copy_64.o (produced from 
arch/x86/lib/csum-copy_64.S). Since I cannot see any specific 
usage of rbp for defining a stackframe. I'm chasing against 
poor performance of a network benchmark and this is what perf produces: 

# Overhead          Command          Shared Object                                         Symbol
# ........  ...............  .....................  .............................................
#
    37.30%            iperf  [kernel.kallsyms]      [k] csum_partial_copy_generic                
                      |
                      --- csum_partial_copy_generic
                         |          
                         |--99.98%-- 0x7f809108b7cd
                         |          |          
                         |          |--69.72%-- 0x20000
                         |          |          
                         |           --30.28%-- 0x7f809108b7c2
                         |                     0x20000
                          --0.02%-- [...]

So this is not very helpful in tracing where this is being 
called from. Presumably somewhere from the networking layer. So 
should objtool catch this or since csum_partial_copy_generic is a leaf
function reliable stack trace isn't needed? Furthermore this function 
is called from C wrapper in csum-wrappers_64.c - shouldn't at least
they be present in the callstack?

This is on 4.6 master from linus and CONFIG_FRAME_POINTER being enabled. 

Regards, 
Nikolay

             reply	other threads:[~2016-05-13 11:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-13 11:07 Nikolay Borisov [this message]
2016-05-16 18:28 ` Stack trace of csum_partial_copy_generic Josh Poimboeuf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5735B583.6090500@kyup.com \
    --to=kernel@kyup.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.