From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] usb: dwc3: fix kconfig
Date: Fri, 13 May 2016 14:43:59 +0200 [thread overview]
Message-ID: <5735CC0F.6050001@denx.de> (raw)
In-Reply-To: <5735C848.1090303@ti.com>
On 05/13/2016 02:27 PM, Roger Quadros wrote:
> On 13/05/16 15:23, Marek Vasut wrote:
>> On 05/13/2016 02:17 PM, Roger Quadros wrote:
>>> DWC3 can be used in host only or gadget only mode.
>>>
>>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>>> ---
>>> drivers/usb/dwc3/Kconfig | 9 +++++----
>>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
>>> index e93398f..caf695b 100644
>>> --- a/drivers/usb/dwc3/Kconfig
>>> +++ b/drivers/usb/dwc3/Kconfig
>>> @@ -1,15 +1,16 @@
>>> config USB_DWC3
>>> bool "DesignWare USB3 DRD Core Support"
>>> - depends on (USB && USB_GADGET)
>>> - select USB_GADGET_DUALSPEED
>>> + depends on (USB || USB_GADGET)
>>> + select USB_GADGET_DUALSPEED if USB_GADGET
>>> help
>>> - Say Y here if your system has a Dual Role SuperSpeed
>>> - USB controller based on the DesignWare USB3 IP Core.
>>> + Say Y here if your system has DesignWare USB3 IP Core.
>>>
>>> if USB_DWC3
>>>
>>> choice
>>> bool "DWC3 Mode Selection"
>>> + default USB_DWC3_HOST if (USB && !USB_GADGET)
>>> + default USB_DWC3_GADGET if (!USB && USB_GADGET)
>>
>> What happens if I select both USB and USB_GADGET ?
>
> Ideally we want to have dual role operation but that code seems
> to have been stripped off from the dwc3/core.c.
>
> So till dual-role is added back it will work in HOST mode by default
> but user can still choose GADGET mode.
All right, not great, but let's go with this.
Thanks
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-05-13 12:43 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 12:17 [U-Boot] [PATCH 0/4] am57xx: beagle-x15: get usb host working Roger Quadros
2016-05-13 12:17 ` [U-Boot] [PATCH 1/4] usb: dwc3: fix kconfig Roger Quadros
2016-05-13 12:23 ` Marek Vasut
2016-05-13 12:27 ` Roger Quadros
2016-05-13 12:43 ` Marek Vasut [this message]
2016-05-17 10:37 ` Masahiro Yamada
2016-05-17 10:33 ` Masahiro Yamada
2016-05-18 12:47 ` Roger Quadros
2016-05-18 12:52 ` Marek Vasut
2016-05-19 14:15 ` [U-Boot] [PATCH v2 " Roger Quadros
2016-05-13 12:17 ` [U-Boot] [PATCH 2/4] board: ti: am57xx: Fix USB configuration Roger Quadros
2016-05-13 12:23 ` Marek Vasut
2016-05-13 12:36 ` [U-Boot] [PATCH v2 " Roger Quadros
2016-05-13 12:45 ` Marek Vasut
2016-05-16 9:06 ` Roger Quadros
2016-05-16 9:26 ` Roger Quadros
2016-05-16 9:49 ` Roger Quadros
2016-05-16 10:03 ` Kishon Vijay Abraham I
2016-05-16 10:31 ` Roger Quadros
2016-05-16 11:10 ` Kishon Vijay Abraham I
2016-05-16 13:51 ` Roger Quadros
2016-05-20 22:32 ` [U-Boot] [U-Boot,2/4] " Tom Rini
2016-05-13 12:17 ` [U-Boot] [PATCH 3/4] usb: dwc3: Makefile: Don't build gadget code if USB_GADGET is disabled Roger Quadros
2016-05-13 12:24 ` Marek Vasut
2016-05-30 17:58 ` [U-Boot] [U-Boot, " Tom Rini
2016-05-13 12:17 ` [U-Boot] [PATCH 4/4] usb: gadget: udc: Build on USB_GADGET Roger Quadros
2016-05-13 12:24 ` Marek Vasut
2016-05-13 12:29 ` Roger Quadros
2016-05-13 12:47 ` Marek Vasut
2016-05-16 9:03 ` Roger Quadros
2016-05-13 12:22 ` [U-Boot] [PATCH 0/4] am57xx: beagle-x15: get usb host working Marek Vasut
2016-05-13 12:39 ` Roger Quadros
2016-05-13 12:47 ` Marek Vasut
2016-05-18 14:27 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5735CC0F.6050001@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.