From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH RESEND 2/2] drm/i915: don't mix bitwise and logical operations for has_snoop
Date: Fri, 13 May 2016 16:08:09 +0100 [thread overview]
Message-ID: <5735EDD9.4080307@linux.intel.com> (raw)
In-Reply-To: <1463148278-23193-2-git-send-email-jani.nikula@intel.com>
On 13/05/16 15:04, Jani Nikula wrote:
> Also make the code more readable.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/i915_dma.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
> index 547100fa3122..a8c79f6512a4 100644
> --- a/drivers/gpu/drm/i915/i915_dma.c
> +++ b/drivers/gpu/drm/i915/i915_dma.c
> @@ -954,9 +954,11 @@ static void intel_device_info_runtime_init(struct drm_device *dev)
> else if (INTEL_INFO(dev)->gen >= 9)
> gen9_sseu_info_init(dev);
>
> - /* Snooping is broken on BXT A stepping. */
> info->has_snoop = !info->has_llc;
> - info->has_snoop &= !IS_BXT_REVID(dev, 0, BXT_REVID_A1);
> +
> + /* Snooping is broken on BXT A stepping. */
> + if (IS_BXT_REVID(dev, 0, BXT_REVID_A1))
> + info->has_snoop = false;
>
> DRM_DEBUG_DRIVER("slice total: %u\n", info->slice_total);
> DRM_DEBUG_DRIVER("subslice total: %u\n", info->subslice_total);
>
Yeah that is more readable.
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-05-13 15:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 14:04 [PATCH RESEND 1/2] drm/i915: make device info bitfield flags bools Jani Nikula
2016-05-13 14:04 ` [PATCH RESEND 2/2] drm/i915: don't mix bitwise and logical operations for has_snoop Jani Nikula
2016-05-13 15:08 ` Tvrtko Ursulin [this message]
2016-05-13 14:25 ` [PATCH RESEND 1/2] drm/i915: make device info bitfield flags bools Tvrtko Ursulin
2016-05-13 14:33 ` Chris Wilson
2016-05-13 14:47 ` Jani Nikula
2016-05-13 15:05 ` Tvrtko Ursulin
2016-05-16 10:46 ` Dave Gordon
2016-05-16 15:24 ` Jani Nikula
2016-05-13 15:05 ` ✗ Ro.CI.BAT: failure for series starting with [RESEND,1/2] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5735EDD9.4080307@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.