From: Manfred Schlaegl <manfred.schlaegl@gmx.at>
To: Thierry Reding <thierry.reding@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Manfred Schlaegl <manfred.schlaegl@ginzinger.com>,
Luis de Bethencourt <luis@debethencourt.com>,
Olivier Sobrie <olivier@sobrie.be>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] Input: pwm-beeper - defer pwm config if pwm can sleep
Date: Fri, 13 May 2016 17:38:11 +0200 [thread overview]
Message-ID: <5735F4E3.20008@gmx.at> (raw)
In-Reply-To: <20160512121852.GB26824@ulmo.ba.sec>
On 2016-05-12 14:18, Thierry Reding wrote:
>
> I agree with Dmitry. Users of the PWM API should always assume that
> calls to the PWM API might sleep. Conditionalizing on pwm_can_sleep()
> isn't a good idea, since that function is scheduled to be removed. In
> fact it's been returning true unconditionally since v4.5, so the fast
> path is dead code anyway.
>
In this case, the decision is clear ;-)
I'll rework and send the new patch in the next days.
best regards,
manfred
next prev parent reply other threads:[~2016-05-13 15:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 13:19 [PATCH] Input: pwm-beeper - defer pwm config if pwm can sleep Manfred Schlaegl
2016-02-22 19:46 ` Dmitry Torokhov
2016-02-23 8:46 ` Manfred Schlaegl
2016-03-30 14:57 ` Manfred Schlaegl
2016-05-12 12:18 ` Thierry Reding
2016-05-13 15:38 ` Manfred Schlaegl [this message]
2016-05-18 15:16 ` [PATCH] Input: pwm-beeper - fix: scheduling while atomic Manfred Schlaegl
2016-05-18 16:06 ` Greg Kroah-Hartman
2016-05-19 7:52 ` Manfred Schlaegl
2016-05-20 16:59 ` Dmitry Torokhov
2016-05-24 8:32 ` Manfred Schlaegl
2016-05-24 8:37 ` Manfred Schlaegl
2016-05-26 0:36 ` Dmitry Torokhov
2016-05-27 8:54 ` Manfred Schlaegl
2016-05-27 9:11 ` Manfred Schlaegl
2016-05-27 9:14 ` Manfred Schlaegl
2016-05-27 23:38 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5735F4E3.20008@gmx.at \
--to=manfred.schlaegl@gmx.at \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luis@debethencourt.com \
--cc=manfred.schlaegl@ginzinger.com \
--cc=olivier@sobrie.be \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.