From: "Christian König" <deathsimple@vodafone.de>
To: Alex Deucher <alexdeucher@gmail.com>, dri-devel@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>
Subject: Re: [PATCH 1/4] tests/amdgpu: expand write/copy tests to compute
Date: Fri, 13 May 2016 20:51:02 +0200 [thread overview]
Message-ID: <57362216.4060108@vodafone.de> (raw)
In-Reply-To: <1463158112-28625-1-git-send-email-alexander.deucher@amd.com>
Am 13.05.2016 um 18:48 schrieb Alex Deucher:
> Uses same packets as gfx.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
For the series Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> tests/amdgpu/basic_tests.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/tests/amdgpu/basic_tests.c b/tests/amdgpu/basic_tests.c
> index 599c090..05ab145 100644
> --- a/tests/amdgpu/basic_tests.c
> +++ b/tests/amdgpu/basic_tests.c
> @@ -813,7 +813,8 @@ static void amdgpu_command_submission_write_linear_helper(unsigned ip_type)
> pm4[i++] = sdma_write_length;
> while(j++ < sdma_write_length)
> pm4[i++] = 0xdeadbeaf;
> - } else if (ip_type == AMDGPU_HW_IP_GFX) {
> + } else if ((ip_type == AMDGPU_HW_IP_GFX) ||
> + (ip_type == AMDGPU_HW_IP_COMPUTE)) {
> pm4[i++] = PACKET3(PACKET3_WRITE_DATA, 2 + sdma_write_length);
> pm4[i++] = WRITE_DATA_DST_SEL(5) | WR_CONFIRM;
> pm4[i++] = 0xfffffffc & bo_mc;
> @@ -911,7 +912,8 @@ static void amdgpu_command_submission_const_fill_helper(unsigned ip_type)
> pm4[i++] = (0xffffffff00000000 & bo_mc) >> 32;
> pm4[i++] = 0xdeadbeaf;
> pm4[i++] = sdma_write_length;
> - } else if (ip_type == AMDGPU_HW_IP_GFX) {
> + } else if ((ip_type == AMDGPU_HW_IP_GFX) ||
> + (ip_type == AMDGPU_HW_IP_COMPUTE)) {
> pm4[i++] = PACKET3(PACKET3_DMA_DATA, 5);
> pm4[i++] = PACKET3_DMA_DATA_ENGINE(0) |
> PACKET3_DMA_DATA_DST_SEL(0) |
> @@ -1030,7 +1032,8 @@ static void amdgpu_command_submission_copy_linear_helper(unsigned ip_type)
> pm4[i++] = (0xffffffff00000000 & bo1_mc) >> 32;
> pm4[i++] = 0xffffffff & bo2_mc;
> pm4[i++] = (0xffffffff00000000 & bo2_mc) >> 32;
> - } else if (ip_type == AMDGPU_HW_IP_GFX) {
> + } else if ((ip_type == AMDGPU_HW_IP_GFX) ||
> + (ip_type == AMDGPU_HW_IP_COMPUTE)) {
> pm4[i++] = PACKET3(PACKET3_DMA_DATA, 5);
> pm4[i++] = PACKET3_DMA_DATA_ENGINE(0) |
> PACKET3_DMA_DATA_DST_SEL(0) |
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-05-13 18:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 16:48 [PATCH 1/4] tests/amdgpu: expand write/copy tests to compute Alex Deucher
2016-05-13 16:48 ` [PATCH 2/4] " Alex Deucher
2016-05-13 16:48 ` [PATCH 3/4] tests/amdgpu: add interface to adapt firmware requirement Alex Deucher
2016-05-13 16:48 ` [PATCH 4/4] tests/amdgpu: adapt to new polaris10/11 uvd fw Alex Deucher
2016-05-14 14:19 ` Emil Velikov
2016-05-14 18:29 ` Christian König
2016-05-15 18:16 ` Emil Velikov
2016-05-16 14:32 ` Jiang, Sonny
2016-05-13 18:51 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57362216.4060108@vodafone.de \
--to=deathsimple@vodafone.de \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.