All of lore.kernel.org
 help / color / mirror / Atom feed
From: Angelo Dureghello <angelo@sysam.it>
To: u-boot@lists.denx.de
Subject: [U-Boot] RFC, dm: devices and device_info platdata manual relocation
Date: Sat, 14 May 2016 12:59:21 +0200	[thread overview]
Message-ID: <57370509.8050402@sysam.it> (raw)

Hi all,

i have seen, updating u-boot in NOR parallel flash,
that the U_BOOT_DEVICE structure "platdata" ptr is
still pointing to flash, so the update (rewriting
flash) die silently and fails.

I have found a workaround using misc_init_r that works
in my board.c, as below, but i don't like too much the solution:

...
#include <dm/platform_data/serial_coldfire.h>
...

DECLARE_GLOBAL_DATA_PTR;
....

int misc_init_r(void)
{
	/*
	 * FIXME: relocation seems not working properly on m68k,
	 * so relocating manually
	 */
	struct udevice *dev;
	int retval;

	printf("misc_init_r(): entering\n");

	retval = uclass_find_device(UCLASS_SERIAL, 0, &dev);

	if (!retval) {
		printf("misc_init_r(): relocating serial device\n");

		dev->platdata += gd->reloc_off;
	}

	return 0;
}

static struct coldfire_serial_platdata mcf5307_serial_plat = {
	.base = CONFIG_SYS_UART_BASE,
	.port = 0,
	.baudrate = CONFIG_BAUDRATE,
};

U_BOOT_DEVICE(coldfire_serial) = {
	.name = "serial_coldfire",
	.platdata = &mcf5307_serial_plat,
};


So, i can keep this changes in my board, but, i am wondering if 
manual-reloc of devices structures is maybe responsibility of
drivers/core/root.c, something like

int dm_init(void)

{

.....
#if defined(CONFIG_NEEDS_MANUAL_RELOC)
	fix_drivers();
	fix_uclass();
	fix_devices(); <-------------
#endif

.....

Every comment is welcome.

Regards,
Angelo Dureghello

             reply	other threads:[~2016-05-14 10:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-14 10:59 Angelo Dureghello [this message]
2016-06-17  3:49 ` [U-Boot] RFC, dm: devices and device_info platdata manual relocation Simon Glass
2016-06-17 12:39   ` Angelo Dureghello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57370509.8050402@sysam.it \
    --to=angelo@sysam.it \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.