From: Guenter Roeck <linux@roeck-us.net>
To: Crestez Dan Leonard <cdleonard@gmail.com>,
Crestez Dan Leonard <leonard.crestez@intel.com>,
linux-i2c@vger.kernel.org
Cc: Jean Delvare <khali@linux-fr.org>
Subject: Re: [PATCH i2c-tools] i2cget: Add support for i2c block data
Date: Sat, 14 May 2016 08:10:13 -0700 [thread overview]
Message-ID: <57373FD5.5070603@roeck-us.net> (raw)
In-Reply-To: <93dcb82b-b04e-4b3c-1868-2a4fe4a086c8@gmail.com>
On 05/14/2016 04:30 AM, Crestez Dan Leonard wrote:
> On 05/14/2016 03:38 AM, Guenter Roeck wrote:
>> On 05/13/2016 11:54 AM, Crestez Dan Leonard wrote:
>>> This adds mode 'i' for I2C_SMBUS_I2C_BLOCK_DATA. This is the same mode
>>> letter from i2cdump.
>>>
>>> Length is optional and defaults to 32 (maximum).
>>>
>>> The indended use is debugging i2c devices with shell commands.
>>>
>> How does this differ from the 'i' option of i2cdump ?
>
> Apparently i2cdump doesn't support a range in "i" mode. I considered adding a range to i2cdump in all modes but:
> - i2cdump code is a more complicated
Maybe, but it already supports the command.
> - Not all devices interpret i2c bulk read as a register range. Reading X bytes from register Y can be different from reading registers from X to X+Y.
>
Not sure I understand what that has to do with supporting i2c block data.
Both commands call i2c_smbus_read_i2c_block_data(). Please explain.
Guenter
next prev parent reply other threads:[~2016-05-14 15:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 18:54 [PATCH i2c-tools] i2cget: Add support for i2c block data Crestez Dan Leonard
2016-05-14 0:38 ` Guenter Roeck
2016-05-14 11:30 ` Crestez Dan Leonard
2016-05-14 15:10 ` Guenter Roeck [this message]
2016-05-16 11:39 ` Crestez Dan Leonard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57373FD5.5070603@roeck-us.net \
--to=linux@roeck-us.net \
--cc=cdleonard@gmail.com \
--cc=khali@linux-fr.org \
--cc=leonard.crestez@intel.com \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.