[PATCH] f2fs: no need inc dirty pages under inode lock

[PATCH] f2fs: no need inc dirty pages under inode lock

[Yunlei He]

No need inc dirty pages under inode lock

Signed-off-by: Yunlei He <heyunlei@huawei.com>
---
 fs/f2fs/checkpoint.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
index 6402e93..3da6499 100644
--- a/fs/f2fs/checkpoint.c
+++ b/fs/f2fs/checkpoint.c
@@ -787,9 +787,9 @@ void update_dirty_page(struct inode *inode, struct page *page)
 
 	spin_lock(&sbi->inode_lock[type]);
 	__add_dirty_inode(inode, type);
-	inode_inc_dirty_pages(inode);
 	spin_unlock(&sbi->inode_lock[type]);
 
+	inode_inc_dirty_pages(inode);
 	SetPagePrivate(page);
 	f2fs_trace_pid(page);
 }
-- 
1.9.1


------------------------------------------------------------------------------
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j

Re: [PATCH] f2fs: no need inc dirty pages under inode lock

[Jaegeuk Kim]

Hi Yunlei,

It's just one atomic operation.
Are there performance or race condition issues?

Thanks,

On Fri, May 13, 2016 at 02:57:43PM +0800, Yunlei He wrote:
> No need inc dirty pages under inode lock
> 
> Signed-off-by: Yunlei He <heyunlei@huawei.com>
> ---
>  fs/f2fs/checkpoint.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
> index 6402e93..3da6499 100644
> --- a/fs/f2fs/checkpoint.c
> +++ b/fs/f2fs/checkpoint.c
> @@ -787,9 +787,9 @@ void update_dirty_page(struct inode *inode, struct page *page)
>  
>  	spin_lock(&sbi->inode_lock[type]);
>  	__add_dirty_inode(inode, type);
> -	inode_inc_dirty_pages(inode);
>  	spin_unlock(&sbi->inode_lock[type]);
>  
> +	inode_inc_dirty_pages(inode);
>  	SetPagePrivate(page);
>  	f2fs_trace_pid(page);
>  }
> -- 
> 1.9.1

------------------------------------------------------------------------------
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j

Re: [PATCH] f2fs: no need inc dirty pages under inode lock

[He YunLei]

Hi, Kim
On 2016/5/14 1:13, Jaegeuk Kim wrote:
> Hi Yunlei,
>
> It's just one atomic operation.
> Are there performance or race condition issues?
>

No race condition issues reported here, but it has no relationship with inode lock, and dec operation
with no this lock. Besides atomic operation, it call set_sbi_flag, maybe it will affect performance

Thanks,

> Thanks,
>
> On Fri, May 13, 2016 at 02:57:43PM +0800, Yunlei He wrote:
>> No need inc dirty pages under inode lock
>>
>> Signed-off-by: Yunlei He <heyunlei@huawei.com>
>> ---
>>   fs/f2fs/checkpoint.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
>> index 6402e93..3da6499 100644
>> --- a/fs/f2fs/checkpoint.c
>> +++ b/fs/f2fs/checkpoint.c
>> @@ -787,9 +787,9 @@ void update_dirty_page(struct inode *inode, struct page *page)
>>
>>   	spin_lock(&sbi->inode_lock[type]);
>>   	__add_dirty_inode(inode, type);
>> -	inode_inc_dirty_pages(inode);
>>   	spin_unlock(&sbi->inode_lock[type]);
>>
>> +	inode_inc_dirty_pages(inode);
>>   	SetPagePrivate(page);
>>   	f2fs_trace_pid(page);
>>   }
>> --
>> 1.9.1
>
> .
>


------------------------------------------------------------------------------
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j