From: Julien Grall <julien.grall@arm.com>
To: Peng Fan <van.freenix@gmail.com>,
xen-devel@lists.xen.org, sstabellini@kernel.org
Subject: Re: [PATCH V3 2/2] xen/arm: mm: clean up code in setup_pagetables
Date: Mon, 16 May 2016 10:22:52 +0100 [thread overview]
Message-ID: <5739916C.1010403@arm.com> (raw)
In-Reply-To: <1463053728-3624-2-git-send-email-van.freenix@gmail.com>
Hi Peng,
On 12/05/16 12:48, Peng Fan wrote:
> The base of address for the relocated xen needs to be mapped
> at the same virtual address (BOOT_RELOC_VIRT_START) in both
> the boot and runtime page tables. So we can merge the two pieces
> of code into on code block
s/on/one/ and missing full stop.
>
> Also no need to use write_pte when mapping BOOT_RELOC_VIRT_START
> in xen_second, because CPU0 is using boot page tables.
>
> Signed-off-by: Peng Fan <van.freenix@gmail.com>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Julien Grall <julien.grall@arm.com>
With the typos above fixed:
Reviewed-by: Julien Grall <julien.grall@arm.com>
Stefano, could you fix the typos before applying this series to your Xen
4.8 branch?
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-16 9:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 11:48 [PATCH V3 1/2] xen/arm: mm: remove unnecessary tlb flush in setup_pagetables Peng Fan
2016-05-12 11:48 ` [PATCH V3 2/2] xen/arm: mm: clean up code " Peng Fan
2016-05-16 9:22 ` Julien Grall [this message]
2016-05-16 10:23 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5739916C.1010403@arm.com \
--to=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=van.freenix@gmail.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.