From: Julien Grall <julien.grall@arm.com>
To: Peng Fan <van.freenix@gmail.com>,
Xen Devel <xen-devel@lists.xen.org>,
sstabellini@kernel.org
Cc: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH V2] xen/arm: mm: fix nr_second calculation in setup_frametable_mappings
Date: Mon, 16 May 2016 10:36:11 +0100 [thread overview]
Message-ID: <5739948B.4020707@arm.com> (raw)
In-Reply-To: <1463058188-4478-1-git-send-email-van.freenix@gmail.com>
(CC Wei for Xen 4.7)
Hi,
On 12/05/16 14:03, Peng Fan wrote:
> On ARM64, "frametable_size >> SECOND_SHIFT" computes the number
> of second level entries, not the number of second level pages.
>
> "ROUNDUP(frametable_size, FIRST_SIZE) >> FIRST_SHIFT" which computes
> the number of the first level entries (the number of second level pages),
> is the correct one that should be used.
>
> Signed-off-by: Peng Fan <van.freenix@gmail.com>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Julien Grall <julien.grall@arm.com>
Reviewed-by: Julien Grall <julien.grall@arm.com>
This is a bug fix for Xen 4.7 and should be backported up to Xen 4.4.
Wei, could we get a release-ack for this patch?
The computation of the number of page to allocation was wrong. This
could result to overrun xen_first on platform with big amount of memory.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-16 9:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 13:03 [PATCH V2] xen/arm: mm: fix nr_second calculation in setup_frametable_mappings Peng Fan
2016-05-16 9:36 ` Julien Grall [this message]
2016-05-16 9:39 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5739948B.4020707@arm.com \
--to=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=van.freenix@gmail.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.