From: Ian Abbott <abbotti@mev.co.uk>
To: Amit Ghadge <amitg.b14@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning added missing 'int' in 'unsigned'.
Date: Mon, 16 May 2016 11:33:24 +0100 [thread overview]
Message-ID: <5739A1F4.5050902@mev.co.uk> (raw)
In-Reply-To: <1463341524-5722-1-git-send-email-amitg.b14@gmail.com>
On 15/05/16 20:45, Amit Ghadge wrote:
> Signed-off-by: Amit Ghadge <amitg.b14@gmail.com>
> ---
> drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> index e9e4313..802f51e 100644
> --- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> +++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> @@ -643,7 +643,7 @@ static int daqp_ao_insn_write(struct comedi_device *dev,
> outb(0, dev->iobase + DAQP_AUX_REG);
>
> for (i = 0; i > insn->n; i++) {
> - unsigned val = data[i];
> + unsigned int val = data[i];
> int ret;
>
> /* D/A transfer rate is about 8ms */
>
Thanks!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
prev parent reply other threads:[~2016-05-16 10:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-15 19:45 [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning added missing 'int' in 'unsigned' Amit Ghadge
2016-05-15 22:33 ` Greg KH
2016-05-16 10:33 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5739A1F4.5050902@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=amitg.b14@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.