From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: Tony Makkiel <tony.makkiel@daqri.com>
Cc: Linux LED Subsystem <linux-leds@vger.kernel.org>,
Stas Sergeev <stsp@users.sourceforge.net>,
Pavel Machek <pavel@ucw.cz>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: Brightness control irrespective of blink state.
Date: Mon, 16 May 2016 16:32:09 +0200 [thread overview]
Message-ID: <5739D9E9.6060801@samsung.com> (raw)
In-Reply-To: <5739D7CC.4040205@samsung.com>
On 05/16/2016 04:23 PM, Jacek Anaszewski wrote:
> On 05/16/2016 03:43 PM, Tony Makkiel wrote:
if (led_cdev->flags & LED_BLINK_SW) .
>>>
>>> LED_BLINK_SW flag would have to be cleared in led_stop_software_blink()
>>> and in the first two conditions in the led_timer_function().
>>>
>>
>> Yes, that will do with minimal changes. I tested the following, and
>> works.
>
> Fine, so could you please submit the patch officially?
> Before that, please rebase your code on top of LED tree or linux-next
> and change LED_BLINKING_SW to LED_BLINK_SW, to keep the same prefix for
> each blinking related definition.
Also please put it before LED_BLINK_ONESHOT.
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2016-05-16 14:32 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 22:03 [PATCH v3 0/3] Extend the LED panic trigger Ezequiel Garcia
2016-04-28 22:03 ` Ezequiel Garcia
2016-04-28 22:03 ` Ezequiel Garcia
2016-04-28 22:03 ` [PATCH v3 1/3] leds: triggers: Allow to switch the trigger to "panic" on a kernel panic Ezequiel Garcia
2016-04-28 22:03 ` Ezequiel Garcia
2016-04-28 22:03 ` Ezequiel Garcia
2016-04-29 7:20 ` Jacek Anaszewski
2016-04-29 7:20 ` Jacek Anaszewski
[not found] ` <57230B26.9010300-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-05-06 9:03 ` Jacek Anaszewski
2016-05-06 9:03 ` Jacek Anaszewski
2016-05-06 9:03 ` Jacek Anaszewski
2016-05-06 13:05 ` Ezequiel Garcia
2016-05-06 13:05 ` Ezequiel Garcia
2016-05-06 18:25 ` Brightness control irrespective of blink state Tony Makkiel
2016-05-06 18:48 ` Jacek Anaszewski
2016-05-09 13:27 ` Tony Makkiel
2016-05-09 14:45 ` Jacek Anaszewski
2016-05-10 9:36 ` Tony Makkiel
2016-05-10 13:26 ` Jacek Anaszewski
2016-05-10 16:55 ` Tony Makkiel
2016-05-11 9:41 ` Jacek Anaszewski
2016-05-11 13:42 ` Tony Makkiel
2016-05-12 10:26 ` Jacek Anaszewski
2016-05-13 14:20 ` Tony Makkiel
2016-05-16 9:21 ` Jacek Anaszewski
2016-05-16 13:43 ` Tony Makkiel
2016-05-16 14:23 ` Jacek Anaszewski
2016-05-16 14:32 ` Jacek Anaszewski [this message]
2016-04-28 22:03 ` [PATCH v3 2/3] devicetree: leds: Introduce "panic-indicator" optional property Ezequiel Garcia
2016-04-28 22:03 ` Ezequiel Garcia
2016-04-28 22:03 ` Ezequiel Garcia
2016-04-28 22:03 ` [PATCH v3 3/3] leds: gpio: Support the "panic-indicator" firmware property Ezequiel Garcia
2016-04-28 22:03 ` Ezequiel Garcia
2016-04-28 22:03 ` Ezequiel Garcia
2016-05-03 16:53 ` Rob Herring
2016-05-03 16:53 ` Rob Herring
2016-04-28 22:22 ` [PATCH v3 0/3] Extend the LED panic trigger Pavel Machek
2016-04-28 22:22 ` Pavel Machek
[not found] ` <1461881020-13964-1-git-send-email-ezequiel-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org>
2016-04-29 18:57 ` Matthias Brugger
2016-04-29 18:57 ` Matthias Brugger
2016-04-29 18:57 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5739D9E9.6060801@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=stsp@users.sourceforge.net \
--cc=tony.makkiel@daqri.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.