From: Eric Blake <eblake@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/6] qemu-io: enable tracing in qemu-io
Date: Mon, 16 May 2016 10:07:50 -0600 [thread overview]
Message-ID: <5739F056.5080404@redhat.com> (raw)
In-Reply-To: <1463227273-27523-2-git-send-email-den@openvz.org>
[-- Attachment #1: Type: text/plain, Size: 899 bytes --]
On 05/14/2016 06:01 AM, Denis V. Lunev wrote:
> It would be convinient to enable tracepoints in qemu-io binary. This would
s/convinient/convenient/
> allow to perform investigations without additional code recompilations.
>
> The command line will be exactly the same as in qemu-system.
Reads awkwardly. Grammar suggestion for the whole commit body:
For convenience, enable tracepoints in the qemu-io binary just like what
is done for qemu-system. This allows trace investigations without
additional code recompilation.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Kevin Wolf <kwolf@redhat.com>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> ---
> qemu-io.c | 43 +++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-05-16 16:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-14 12:01 [Qemu-devel] [PATCH 0/6] qcow2_co_write_zeroes and related improvements Denis V. Lunev
2016-05-14 12:01 ` [Qemu-devel] [PATCH 1/6] qemu-io: enable tracing in qemu-io Denis V. Lunev
2016-05-16 13:09 ` Paolo Bonzini
2016-05-16 13:21 ` Denis V. Lunev
2016-05-16 16:07 ` Eric Blake [this message]
2016-05-14 12:01 ` [Qemu-devel] [PATCH 2/6] block: split write_zeroes always Denis V. Lunev
2016-05-16 16:13 ` Eric Blake
2016-05-14 12:01 ` [Qemu-devel] [PATCH 3/6] qcow2: simplify logic in qcow2_co_write_zeroes Denis V. Lunev
2016-05-16 16:28 ` Eric Blake
2016-05-14 12:01 ` [Qemu-devel] [PATCH 4/6] qcow2: add tracepoints for qcow2_co_write_zeroes Denis V. Lunev
2016-05-16 16:32 ` Eric Blake
2016-05-16 16:48 ` Denis V. Lunev
2016-05-14 12:01 ` [Qemu-devel] [PATCH 5/6] qcow2: fix condition in is_zero_cluster Denis V. Lunev
2016-05-14 12:01 ` [Qemu-devel] [PATCH 6/6] qcow2: merge is_zero_cluster helpers into qcow2_co_write_zeroes Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5739F056.5080404@redhat.com \
--to=eblake@redhat.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.