From: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 4/5] malta: Tidy up UART address selection
Date: Mon, 16 May 2016 20:57:38 +0200 [thread overview]
Message-ID: <573A1822.6020800@gmail.com> (raw)
In-Reply-To: <1463420679-5042-5-git-send-email-paul.burton@imgtec.com>
Am 16.05.2016 um 19:44 schrieb Paul Burton:
> The address of the UART differs based upon the system controller because
> it's actually within the I/O port region, which is in a different
> location for each system controller. Rather than handling this as 2
> UARTs with the correct one selected at runtime, use I/O port accessors
> for the UART such that access to it gets translated into the I/O port
> region automatically.
>
> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Reviewed-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> ---
>
> Changes in v2:
> - New patch, simplifying the later DT conversion.
>
> board/imgtec/malta/malta.c | 13 -------------
> include/configs/malta.h | 4 ++--
> 2 files changed, 2 insertions(+), 15 deletions(-)
>
> diff --git a/board/imgtec/malta/malta.c b/board/imgtec/malta/malta.c
> index 3a9e780..4955043 100644
> --- a/board/imgtec/malta/malta.c
> +++ b/board/imgtec/malta/malta.c
> @@ -12,7 +12,6 @@
> #include <pci_gt64120.h>
> #include <pci_msc01.h>
> #include <rtc.h>
> -#include <serial.h>
>
> #include <asm/addrspace.h>
> #include <asm/io.h>
> @@ -161,18 +160,6 @@ int misc_init_r(void)
> return 0;
> }
>
> -struct serial_device *default_serial_console(void)
> -{
> - switch (malta_sys_con()) {
> - case SYSCON_GT64120:
> - return &eserial1_device;
> -
> - default:
> - case SYSCON_MSC01:
> - return &eserial2_device;
> - }
> -}
> -
> void pci_init_board(void)
> {
> pci_dev_t bdf;
> diff --git a/include/configs/malta.h b/include/configs/malta.h
> index 04dca71..1c3c83c 100644
> --- a/include/configs/malta.h
> +++ b/include/configs/malta.h
> @@ -67,10 +67,10 @@
> #define CONFIG_BAUDRATE 115200
>
> #define CONFIG_SYS_NS16550_SERIAL
> +#define CONFIG_SYS_NS16550_PORT_MAPPED
> #define CONFIG_SYS_NS16550_REG_SIZE 1
> #define CONFIG_SYS_NS16550_CLK (115200 * 16)
> -#define CONFIG_SYS_NS16550_COM1 0xb80003f8
> -#define CONFIG_SYS_NS16550_COM2 0xbb0003f8
> +#define CONFIG_SYS_NS16550_COM1 0x3f8
> #define CONFIG_CONS_INDEX 1
>
> /*
>
--
- Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160516/1c340218/attachment.sig>
next prev parent reply other threads:[~2016-05-16 18:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 17:44 [U-Boot] [PATCH v2 0/5] Malta UART using device model & device tree Paul Burton
2016-05-16 17:44 ` [U-Boot] [PATCH v2 1/5] fdt: Support for ISA busses Paul Burton
2016-05-17 12:11 ` Simon Glass
2016-05-16 17:44 ` [U-Boot] [PATCH v2 2/5] fdt: Document the rest of struct of_bus Paul Burton
2016-05-17 12:11 ` Simon Glass
2016-05-16 17:44 ` [U-Boot] [PATCH v2 3/5] dm: ns16550: Don't map_physmem for I/O ports Paul Burton
2016-05-16 18:58 ` Daniel Schwierzeck
2016-05-17 12:11 ` Simon Glass
2016-05-17 12:48 ` Paul Burton
2016-05-17 15:51 ` Daniel Schwierzeck
2016-05-17 15:54 ` Simon Glass
2016-05-17 15:58 ` Paul Burton
2016-05-17 16:00 ` Simon Glass
2016-05-18 10:04 ` Daniel Schwierzeck
2016-05-18 14:52 ` Simon Glass
2016-05-21 16:50 ` Daniel Schwierzeck
2016-05-24 15:34 ` Paul Burton
2016-05-16 17:44 ` [U-Boot] [PATCH v2 4/5] malta: Tidy up UART address selection Paul Burton
2016-05-16 18:57 ` Daniel Schwierzeck [this message]
2016-05-16 17:44 ` [U-Boot] [PATCH v2 5/5] malta: Use device model & tree for UART Paul Burton
2016-05-16 18:56 ` Daniel Schwierzeck
2016-05-17 6:40 ` Paul Burton
2016-05-17 10:57 ` Daniel Schwierzeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573A1822.6020800@gmail.com \
--to=daniel.schwierzeck@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.