From: Jens Axboe <axboe@kernel.dk>
To: "Michael Schoberg (mschoberg)" <mschoberg@micron.com>,
"fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: Windows crash in ctime_r()
Date: Mon, 16 May 2016 19:24:42 -0600 [thread overview]
Message-ID: <573A72DA.2080208@kernel.dk> (raw)
In-Reply-To: <f803f397a70446f98a8af0a14634cb31@bowex36a.micron.com>
On 05/16/2016 03:50 PM, Michael Schoberg (mschoberg) wrote:
> I think I found an issue in os\windows\posix.c that results in a FIO
> crash (on Windows.) I'm including a patch that resolves the crash for
> us, but includes another (optional) fix. > > Crash issue: possix.c -
> ctime_r() will reference a negative array index on Sunday. SYSTEMTIME
> states the days of the week as: "0=Sunday, .. , 6=Saturday." The "fix"
> can likely be dialed back to safely assume the days/months will adhere
> to how they're documented.
>
>
> Optional - StringCchPrintfA() calls should allow for the string plus a
> NULL character. Instead, the value getting passed in is for the entire
> string size.
Thanks, both look good, applied.
--
Jens Axboe
prev parent reply other threads:[~2016-05-17 1:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 21:50 Windows crash in ctime_r() Michael Schoberg (mschoberg)
2016-05-17 1:24 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573A72DA.2080208@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=mschoberg@micron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.