From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60679) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2VBb-0004sQ-DO for qemu-devel@nongnu.org; Mon, 16 May 2016 22:56:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2VBX-0003rU-61 for qemu-devel@nongnu.org; Mon, 16 May 2016 22:56:42 -0400 Received: from [59.151.112.132] (port=33883 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2VBW-0003qp-Ox for qemu-devel@nongnu.org; Mon, 16 May 2016 22:56:39 -0400 References: <1462508442-9407-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1462508442-9407-11-git-send-email-caoj.fnst@cn.fujitsu.com> <57387529.5060203@redhat.com> From: Cao jin Message-ID: <573A8963.6010209@cn.fujitsu.com> Date: Tue, 17 May 2016 11:00:51 +0800 MIME-Version: 1.0 In-Reply-To: <57387529.5060203@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 10/11] pci core: assert ENOSPC when add capability List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Markus Armbruster On 05/15/2016 09:10 PM, Marcel Apfelbaum wrote: > On 05/06/2016 07:20 AM, Cao jin wrote: >> ENOSPC is programming error, assert it for debugging. >> >> + /* out of PCI config space should be programming error */ > > 'is', not 'should be' Will fix it. Thank You, Marcel. I guess I should put this one as the 1st patch in the series, and remove the "ENOSPC" line in the comment of msi_init(), sorry for this stupid fault -- Yours Sincerely, Cao jin