From: Paolo Bonzini <pbonzini@redhat.com>
To: Wei Yang <richard.weiyang@gmail.com>, Andrew Jones <drjones@redhat.com>
Cc: kvm@vger.kernel.org, lvivier@redhat.com, thuth@redhat.com
Subject: Re: [kvm-unit-tests PATCH v2 1/2] arm/arm64: Makefile cleanup
Date: Tue, 17 May 2016 14:35:21 +0200 [thread overview]
Message-ID: <573B1009.10805@redhat.com> (raw)
In-Reply-To: <20160514133040.GA20422@vultr.guest>
On 14/05/2016 15:30, Wei Yang wrote:
> On Tue, May 10, 2016 at 06:55:43PM +0200, Andrew Jones wrote:
>> This does the same cleanup as 'x86: Makefile refine'. .PRECIOUS
>> is used (as opposed to .SECONDARY), because .SECONDARY doesn't
>> accept target patterns.
>>
>> Signed-off-by: Andrew Jones <drjones@redhat.com>
>
> Is it possible to add
>
> Reviewed-by: Wei Yang <richard.weiyang@gmail.com>
Too late, sorry; the commit has been pushed already.
Paolo
> Now?
>
>> ---
>> arm/Makefile.common | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/arm/Makefile.common b/arm/Makefile.common
>> index 9a2d61fc88a27..a786fcf94154f 100644
>> --- a/arm/Makefile.common
>> +++ b/arm/Makefile.common
>> @@ -24,6 +24,9 @@ CFLAGS += -Wextra
>> CFLAGS += -O2
>> CFLAGS += -I lib -I lib/libfdt
>>
>> +# We want to keep intermediate files
>> +.PRECIOUS: %.elf %.o
>> +
>> asm-offsets = lib/$(ARCH)/asm-offsets.h
>> include scripts/asm-offsets.mak
>>
>> @@ -48,7 +51,7 @@ start_addr := $(shell printf "%x\n" $$(( $(phys_base) + $(kernel_offset) )))
>>
>> FLATLIBS = $(libcflat) $(LIBFDT_archive) $(libgcc) $(libeabi)
>> %.elf: LDFLAGS = $(CFLAGS) -nostdlib
>> -%.elf: %.o $(FLATLIBS) arm/flat.lds
>> +%.elf: %.o $(FLATLIBS) arm/flat.lds $(cstart.o)
>> $(CC) $(LDFLAGS) -o $@ \
>> -Wl,-T,arm/flat.lds,--build-id=none,-Ttext=$(start_addr) \
>> $(filter %.o, $^) $(FLATLIBS)
>> @@ -69,7 +72,4 @@ generated_files = $(asm-offsets)
>>
>> test_cases: $(generated_files) $(tests-common) $(tests)
>>
>> -$(TEST_DIR)/selftest.elf: $(cstart.o) $(TEST_DIR)/selftest.o
>> -$(TEST_DIR)/spinlock-test.elf: $(cstart.o) $(TEST_DIR)/spinlock-test.o
>> -
>> $(TEST_DIR)/selftest.o $(cstart.o): $(asm-offsets)
>> --
>> 2.4.11
>
next prev parent reply other threads:[~2016-05-17 12:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 16:55 [kvm-unit-tests PATCH v2 0/2] arm/powerpc: Makefile cleanup Andrew Jones
2016-05-10 16:55 ` [kvm-unit-tests PATCH v2 1/2] arm/arm64: " Andrew Jones
2016-05-10 17:03 ` Paolo Bonzini
2016-05-14 13:30 ` Wei Yang
2016-05-17 12:35 ` Paolo Bonzini [this message]
2016-05-18 22:40 ` Wei Yang
2016-05-19 10:35 ` Paolo Bonzini
2016-05-10 16:55 ` [kvm-unit-tests PATCH v2 2/2] powerpc/ppc64: " Andrew Jones
2016-05-14 13:32 ` Wei Yang
2016-05-10 17:04 ` [kvm-unit-tests PATCH v2 0/2] arm/powerpc: " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573B1009.10805@redhat.com \
--to=pbonzini@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=richard.weiyang@gmail.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.