From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas.Palix@imag.fr (Nicolas Palix (LIG)) Date: Tue, 17 May 2016 16:32:41 +0200 Subject: [Cocci] [PATCH] coccicheck: Fix missing 0 index in kill loop In-Reply-To: <20160516125558.GA352@www.outflux.net> References: <20160516125558.GA352@www.outflux.net> Message-ID: <573B2B89.7060004@imag.fr> To: cocci@systeme.lip6.fr List-Id: cocci@systeme.lip6.fr Le 16/05/16 14:55, Kees Cook a ?crit : > By default, "seq" counts from 1, but processes were starting counting > from 0, so when interrupted, coccicheck would leave the 0th process > running. > > Signed-off-by: Kees Cook Acked-by: Nicolas Palix > --- > scripts/coccicheck | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/coccicheck b/scripts/coccicheck > index b2d758188f2f..dd85a455b2ba 100755 > --- a/scripts/coccicheck > +++ b/scripts/coccicheck > @@ -98,7 +98,7 @@ run_cmd() { > } > > kill_running() { > - for i in $(seq $(( NPROC - 1 )) ); do > + for i in $(seq 0 $(( NPROC - 1 )) ); do > if [ $VERBOSE -eq 2 ] ; then > echo "Killing ${SPATCH_PID[$i]}" > fi > -- Nicolas Palix http://lig-membres.imag.fr/palix/ -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 2959 bytes Desc: Signature cryptographique S/MIME URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755547AbcEQOut (ORCPT ); Tue, 17 May 2016 10:50:49 -0400 Received: from mx2.imag.fr ([129.88.30.17]:57819 "EHLO mx2.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751243AbcEQOus (ORCPT ); Tue, 17 May 2016 10:50:48 -0400 X-Greylist: delayed 1072 seconds by postgrey-1.27 at vger.kernel.org; Tue, 17 May 2016 10:50:47 EDT Subject: Re: [PATCH] coccicheck: Fix missing 0 index in kill loop To: Kees Cook , Julia Lawall References: <20160516125558.GA352@www.outflux.net> Cc: linux-kernel@vger.kernel.org, Gilles Muller , Michal Marek , cocci@systeme.lip6.fr From: "Nicolas Palix (LIG)" Openpgp: id=7DB0096D90E6F00590E3040F6822C99FFBD3F698 Organization: UJF Polytech / LIG Erods Message-ID: <573B2B89.7060004@imag.fr> Date: Tue, 17 May 2016 16:32:41 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160516125558.GA352@www.outflux.net> Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="------------ms010904060600090008050704" X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (mx2.imag.fr [129.88.30.17]); Tue, 17 May 2016 16:32:40 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: u4HEWdSN023927 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: nicolas.palix@imag.fr MailScanner-NULL-Check: 1464100363.96054@JnqL0ns4hAtONS8Ra2FJ7A Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is a cryptographically signed message in MIME format. --------------ms010904060600090008050704 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Le 16/05/16 14:55, Kees Cook a =E9crit : > By default, "seq" counts from 1, but processes were starting counting > from 0, so when interrupted, coccicheck would leave the 0th process > running. >=20 > Signed-off-by: Kees Cook Acked-by: Nicolas Palix > --- > scripts/coccicheck | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/scripts/coccicheck b/scripts/coccicheck > index b2d758188f2f..dd85a455b2ba 100755 > --- a/scripts/coccicheck > +++ b/scripts/coccicheck > @@ -98,7 +98,7 @@ run_cmd() { > } > =20 > kill_running() { > - for i in $(seq $(( NPROC - 1 )) ); do > + for i in $(seq 0 $(( NPROC - 1 )) ); do > if [ $VERBOSE -eq 2 ] ; then > echo "Killing ${SPATCH_PID[$i]}" > fi >=20 --=20 Nicolas Palix http://lig-membres.imag.fr/palix/ --------------ms010904060600090008050704 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: Signature cryptographique S/MIME MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCC CG8wggO2MIICnqADAgECAgEDMA0GCSqGSIb3DQEBBQUAMCwxCzAJBgNVBAYTAkZSMQ0wCwYD VQQKEwRDTlJTMQ4wDAYDVQQDEwVDTlJTMjAeFw0wOTAxMjEwOTAzNTJaFw0yOTAxMjAwOTAz NTJaMDUxCzAJBgNVBAYTAkZSMQ0wCwYDVQQKEwRDTlJTMRcwFQYDVQQDEw5DTlJTMi1TdGFu ZGFyZDCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAJypZGq0ByMZw74ICMTiKl3t 1Cje/j+g7ZJEaxZHNRM3jXSp9U2D5AUbjwhhTN53W9ep/7tlncmsPA/xiXuTIqBHD18Gvo54 oAt510JlYXJjkkCKW2cQ+tYnPth3TR55229LEgBSWOLYQgWyMzd34I1sHbz49vKUWCX3gtmG 2Vzz2C7N/XCJBIfvOdEq2JKMaS8cUmX6YI8Qf8yP+VwuFO1Mi+CdN7jSPJTKUP1Bet72POyu 7L1cFt2w8HOZeoH/OzPSAJ5NjMZbOC4zw3aGynJU2y3iEP2SUGiThO13qYlpUYXr4JSj+ZcI EYwk8A+6OLQs1tdsTmP+tDGf74+mWqUCAwEAAaOB2TCB1jAPBgNVHRMBAf8EBTADAQH/MB0G A1UdDgQWBBQR49nRUkcbWbE8G3hma/ShiO0KWzBUBgNVHSMETTBLgBRQl7YN96wzF6/xHUY8 azv/AKDl5aEwpC4wLDELMAkGA1UEBhMCRlIxDTALBgNVBAoTBENOUlMxDjAMBgNVBAMTBUNO UlMyggEAMA4GA1UdDwEB/wQEAwIBBjA+BgNVHR8ENzA1MDOgMaAvhi1odHRwOi8vY3Jscy5z ZXJ2aWNlcy5jbnJzLmZyL0NOUlMyL2dldGRlci5jcmwwDQYJKoZIhvcNAQEFBQADggEBAE/p 4xfmTCf1F2pQVeruz0yqve4s3XY+WaAvC2iJ2kPQHh0saxL5ZxOeZSukhNIxz4Kgyu8i6BBs 6c8XfKyth4VMiuHVe0zm2Q6yoeQpniCvDz57uX8kTDLgiP562qwWYKF1romcimadlLp+qw4g I+33x4RdgkgU3sTUsMVOLIfUjQMRLzbVKW+umWcZDI1tWiDf0Z/Gy69V7gvKsVsP71x09PNG iWNHfizOv8gwDQBG9hjmbD8wfpBuEI0fOUnPk2nryJ7CZ3OvSov2fEIo3aXd7a/JVRtkP1S8 YSYQ65HV6ffu0PYLC/qmkN1g9ECdC6ec+M4vITj+qwa/2g13+mcwggSxMIIDmaADAgECAgMA sYYwDQYJKoZIhvcNAQEFBQAwNTELMAkGA1UEBhMCRlIxDTALBgNVBAoTBENOUlMxFzAVBgNV BAMTDkNOUlMyLVN0YW5kYXJkMB4XDTE2MDMzMTE0MzczN1oXDTE4MDMzMTE0MzczN1owbDEL MAkGA1UEBhMCRlIxDTALBgNVBAoTBENOUlMxEDAOBgNVBAsTB1VNUjUyMTcxFjAUBgNVBAMT DU5pY29sYXMgUGFsaXgxJDAiBgkqhkiG9w0BCQEWFU5pY29sYXMuUGFsaXhAaW1hZy5mcjCC ASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAOrXeKVCpb7MjlNJjUttPdthNS7GvU/h TZezIPCzuM73eHIpYNVx0qVsnP6fTzAc+7i7a/hAcTM2XChLkm+tzpbWJ44CNoQ9+OCgMW+3 6sRS1Kv66bz1qKqxj4hXnWoGga/ND4bbMmtS0tG+LZ0jpqk5p2K01DU12XnmQ5zi5O+eV0i1 ERLJkJd+m9duJOCa9tni/b05Lcs2LClfYFrmr1cMvGPmy0UguRYrlWjQrMKddLLmMgo8cv4n GebpUfcgo3WmOz4BxKjNzj551Quy2QVtg3gYvuUEtNW88ONofmJ3+wr++ialKRPZM0C1MaCN c6HJ//GVMWldxs0dQLrqUs8CAwEAAaOCAZEwggGNMAwGA1UdEwEB/wQCMAAwEQYJYIZIAYb4 QgEBBAQDAgSwMA4GA1UdDwEB/wQEAwIF4DB6BglghkgBhvhCAQ0EbRZrQ2VydGlmaWNhdCBD TlJTMi1TdGFuZGFyZC4gUG91ciB0b3V0ZSBpbmZvcm1hdGlvbiBzZSByZXBvcnRlciDgIGh0 dHA6Ly9pZ2Muc2VydmljZXMuY25ycy5mci9DTlJTMi1TdGFuZGFyZC8wHQYDVR0OBBYEFLd6 +Ifph9Z/6Ky//jQzMhNtCru7MFQGA1UdIwRNMEuAFBHj2dFSRxtZsTwbeGZr9KGI7QpboTCk LjAsMQswCQYDVQQGEwJGUjENMAsGA1UEChMEQ05SUzEOMAwGA1UEAxMFQ05SUzKCAQMwIAYD VR0RBBkwF4EVTmljb2xhcy5QYWxpeEBpbWFnLmZyMEcGA1UdHwRAMD4wPKA6oDiGNmh0dHA6 Ly9jcmxzLnNlcnZpY2VzLmNucnMuZnIvQ05SUzItU3RhbmRhcmQvZ2V0ZGVyLmNybDANBgkq hkiG9w0BAQUFAAOCAQEAhowl+iLEKBtHY1ygh+luUrBwA/a0PnqnR4Ih92ywgJZ+8yawSpuw p3pqgXAi0WVqWN5fIYZII954W4XwUAedKxdBvOqLXfI1XwwnkhZ09icVWPJX0JZUBfVtKE9x 7sYtD5sknfFNX8dOoy88B1USDVw9BCoOdFr6fMOB+hmneZ/v+Wdj2RTir3IY6xDocwTAfJ4n DdngikVPugfoUyNWR04J1bD9AVj2tNsZIu5cMgsj6ZISpRYHstB7LBx9Ya1zScctTGAT2fup DiiEzqGjJcUSZUMuuvJmIR6v4toqr03yxR90yCn0eiLJOXtHGqOogAaXIGGDHGMS6KIU2hM8 CTGCAt4wggLaAgEBMDwwNTELMAkGA1UEBhMCRlIxDTALBgNVBAoTBENOUlMxFzAVBgNVBAMT DkNOUlMyLVN0YW5kYXJkAgMAsYYwDQYJYIZIAWUDBAIBBQCgggFzMBgGCSqGSIb3DQEJAzEL BgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTE2MDUxNzE0MzI0MVowLwYJKoZIhvcNAQkE MSIEIAluYDA1Pge7DQdWn1+mxQCVwfaikLvYNnYnptpSri9bMEsGCSsGAQQBgjcQBDE+MDww NTELMAkGA1UEBhMCRlIxDTALBgNVBAoTBENOUlMxFzAVBgNVBAMTDkNOUlMyLVN0YW5kYXJk AgMAsYYwTQYLKoZIhvcNAQkQAgsxPqA8MDUxCzAJBgNVBAYTAkZSMQ0wCwYDVQQKEwRDTlJT MRcwFQYDVQQDEw5DTlJTMi1TdGFuZGFyZAIDALGGMGwGCSqGSIb3DQEJDzFfMF0wCwYJYIZI AWUDBAEqMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzAOBggqhkiG9w0DAgICAIAwDQYIKoZI hvcNAwICAUAwBwYFKw4DAgcwDQYIKoZIhvcNAwICASgwDQYJKoZIhvcNAQEBBQAEggEArwXO zbz5V9z4rtjNR6X1m6ZJvoLGHKQ3J/UoApQg1d6XHB9WlOpW1jo8V+AMe6hTRScUmpBCwIVt 9ImnWRrN4yJbG+sqWpLLy1NuGttStNatsE4LXA+TKChe5tQfcOb5QOzTDznBp5j0kcJDflWx cQwHleD0kb4s8Hm3qWzETOIHioHwb6HxJt9qUyDU/yLD/wYApoR3vvTmQ7XQT7kjRVSIKOxC 7eEl+bKw1iM8JTBqe1Y/FK56q9UK5SMAB4ICuM7pT2JPL1V9ItOqKKxcwa2EFRxVqHQFbnBI BjIdWyNtUPA0wOpu5rTy3FRUh40H9XM2HJv6Dn5LJvGqhairiAAAAAAAAA== --------------ms010904060600090008050704--