From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55311) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2hVO-0000PT-MP for qemu-devel@nongnu.org; Tue, 17 May 2016 12:06:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2hVJ-0003JJ-Jc for qemu-devel@nongnu.org; Tue, 17 May 2016 12:05:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37903) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2hVJ-0003Ip-BB for qemu-devel@nongnu.org; Tue, 17 May 2016 12:05:53 -0400 References: <1455640486-6101-1-git-send-email-pbonzini@redhat.com> <1455640486-6101-24-git-send-email-pbonzini@redhat.com> <20160517095339.GD28935@redhat.com> <573B342E.8030208@redhat.com> <5ED6FB6F-5023-4833-83F9-B24BD379E2CD@alex.org.uk> <573B3E3E.60902@redhat.com> <20160517155820.GZ1683@redhat.com> From: Eric Blake Message-ID: <573B415E.6080208@redhat.com> Date: Tue, 17 May 2016 10:05:50 -0600 MIME-Version: 1.0 In-Reply-To: <20160517155820.GZ1683@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PXvDUL0GMHTPSElNi9f7XcDuQvGEj0hH6" Subject: Re: [Qemu-devel] [Nbd] [PULL 23/28] nbd: always query export list in fixed new style protocol List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Richard W.M. Jones" Cc: Alex Bligh , Paolo Bonzini , "Daniel P. Berrange" , "nbd-general@lists.sourceforge.net" , "qemu-devel@nongnu.org" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PXvDUL0GMHTPSElNi9f7XcDuQvGEj0hH6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/17/2016 09:58 AM, Richard W.M. Jones wrote: > On Tue, May 17, 2016 at 09:52:30AM -0600, Eric Blake wrote: >> so it might be nicer to >> make a change to the protocol document that instead permits current >> nbdkit behavior and puts the burden on clients to interoperate when >> NBD_OPT_LIST is not supported. >=20 > The purpose of nbdkit is to be a server for qemu, to be a replacement > for qemu-nbd in cases where proprietary code cannot be combined with > qemu for copyright/licensing/legal reasons. So we aim to make sure we > can interoperate with qemu. No need to change any standards for > nbdkit! Clarifying standards documents is OK though. I also noticed that nbdkit forcefully rejects a client that sends more than 32 NBD_OPT_ commands, even though this is perfectly valid behavior on the part of the client. Maybe the protocol should document a (higher) limit on minimum number of options a client can expect to be serviced before the server dropping the connection because the client is wasting the server's time. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --PXvDUL0GMHTPSElNi9f7XcDuQvGEj0hH6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXO0FeAAoJEKeha0olJ0Nq7w4IAJ0rRAFM0IcKOKhU9PAKMtD+ zcPi7DxSOAJuYXe9zPOdJoxL52ErrZoujCVWUWpHNjjb/0xidBOj7N0qwvdqMRDP DDztdBC4YZje2W270wUJmkVsL0uhYCsIRiPKF9dNYNHF1FvuVMe88cTsfuKgkkeI M0Tqydu1By9co14z61hAyRV9TIvpg5wTMhRmnIfSi+g91+1RJxGGpJzlr8KATDdo nqTVyorh/3FvNd3riZJwgNne20wIE9UFHuJAcaChqb6K+luGpgaOv1u/fsHZXXYq LW8uiKqzyhqtF1fmeWoepDiechRyU8FowWy/T9GcSAnT5nYzmhX2s7it4mfPFzI= =a8wC -----END PGP SIGNATURE----- --PXvDUL0GMHTPSElNi9f7XcDuQvGEj0hH6--