From: Michal Simek <michal.simek@xilinx.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] test/py: Detect timeout in phy negotiation
Date: Tue, 17 May 2016 19:03:18 +0200 [thread overview]
Message-ID: <573B4ED6.2000607@xilinx.com> (raw)
In-Reply-To: <573B4E26.7070909@wwwdotorg.org>
On 17.5.2016 19:00, Stephen Warren wrote:
> On 05/17/2016 10:56 AM, Michal Simek wrote:
>> Hi Stephen,
>>
>> On 17.5.2016 18:50, Stephen Warren wrote:
>>> On 05/17/2016 07:57 AM, Michal Simek wrote:
>>>> If timeout happen it should be reported as fault.
>>>
>>> Presumably if a timeout occurs, the expected text does not appear, i.e.
>>> the existing assert fails anyway?
>>>
>>> Anyway, it's useful to point out problems explicitly, so,
>>> Acked-by: Stephen Warren <swarren@nvidia.com>
>>
>> Unfortunately I found this issue when I was checking logs where I am
>> getting this.
>>
>> ethernet at e000b000 Waiting for PHY auto negotiation to complete.........
>> TIMEOUT !
>> BOOTP broadcast 1
>> BOOTP broadcast 2
>> BOOTP broadcast 3
>> DHCP client bound to address 192.168.0.107 (882 ms)
>> Zynq> .Zynq> setenv serverip 192.168.0.105
>>
>> I haven't looked at the exact reason why it is failing but IMHO it is
>> worth to check.
>
> Oh, in that case I think I should withdraw my ack; in the log above, the
> operation completed successfully, so I'm not convinced the test should
> be marked a failure. I thought this change simply provided more detail
> re: the cause of a test failure.
Is there any other way how to run just phy negotiation and mark this
test as fail?
Thanks
Michal
next prev parent reply other threads:[~2016-05-17 17:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 13:57 [U-Boot] [PATCH] test/py: Detect timeout in phy negotiation Michal Simek
2016-05-17 16:50 ` Stephen Warren
2016-05-17 16:56 ` Michal Simek
2016-05-17 17:00 ` Stephen Warren
2016-05-17 17:03 ` Michal Simek [this message]
2016-05-17 17:36 ` Stephen Warren
2016-05-17 18:00 ` Michal Simek
2016-05-17 19:09 ` Stephen Warren
2016-05-18 10:56 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573B4ED6.2000607@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.