All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] syscalls/fanotify*: Cleanup && fix compiler warnings
Date: Wed, 18 May 2016 08:51:26 +0800	[thread overview]
Message-ID: <573BBC8E.4090400@cn.fujitsu.com> (raw)
In-Reply-To: <20160517121121.GB12051@rei.lan>


> Hi!
>>   testcases/kernel/syscalls/fanotify/fanotify.h   | 57 -------------------------
> Looking at the code indeed the testcases have
>
> #if defined(HAVE_SYS_FANOTIFY_H)
>
> #endif
>
> Around the whole test code so the wrappers are not used at all.
>
> But you should really describe exactly that in the commit description so
> that it's clear why this header could be removed.
>
> We may also try to remove the #ifdefs from the testcases so they are
> compiled even on glibc 2.12 and older (which is not that old). I guess
> is that these testcases will compile fine, but we would have to add
> configure check for linux/fanotify.h which would have to be included
> before the fanotify wrappers to get the FAN_* constants defined. And
> also create fallback definitions or skip the test compilation if both
> sys/fanotify.h and linux/fanotify.h was misssing.
>
Hi Cyril
thanks for your response, so i will rewrite this patch.



  reply	other threads:[~2016-05-18  0:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-12  7:18 [LTP] [PATCH 1/2] syscalls/pipe01: Cleanup && convert to new API Xiao Yang
2016-05-12  7:18 ` [LTP] [PATCH 2/2] syscalls/fanotify*: Cleanup && fix compiler warnings Xiao Yang
2016-05-17 12:11   ` Cyril Hrubis
2016-05-18  0:51     ` Xiao Yang [this message]
2016-06-16  2:30     ` [LTP] [PATCH v2] syscalls/fanotify*: Cleanup Xiao Yang
2016-09-22 14:27       ` Cyril Hrubis
2016-05-17 11:44 ` [LTP] [PATCH 1/2] syscalls/pipe01: Cleanup && convert to new API Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=573BBC8E.4090400@cn.fujitsu.com \
    --to=yangx.jy@cn.fujitsu.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.