From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753193AbcERKV6 (ORCPT ); Wed, 18 May 2016 06:21:58 -0400 Received: from smtp97.iad3a.emailsrvr.com ([173.203.187.97]:37568 "EHLO smtp97.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752602AbcERKV5 (ORCPT ); Wed, 18 May 2016 06:21:57 -0400 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH 01/14] staging: comedi: daqboard2000: remove commented out code To: Hartley Sweeten , "devel@driverdev.osuosl.org" References: <1463478773-5916-1-git-send-email-abbotti@mev.co.uk> <1463478773-5916-2-git-send-email-abbotti@mev.co.uk> Cc: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" From: Ian Abbott Message-ID: <573C4242.2010507@mev.co.uk> Date: Wed, 18 May 2016 11:21:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/05/16 18:14, Hartley Sweeten wrote: > On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: >> Remove some commented out code. Some of it uses constructs that don't >> exist in the driver, and probably come from the source code for the MS >> Windows driver. >> >> Signed-off-by: Ian Abbott >> --- >> drivers/staging/comedi/drivers/daqboard2000.c | 6 ------ >> 1 file changed, 6 deletions(-) >> >> diff --git a/drivers/staging/comedi/drivers/daqboard2000.c b/drivers/staging/comedi/drivers/daqboard2000.c >> index 57ab668..8c9a024 100644 >> --- a/drivers/staging/comedi/drivers/daqboard2000.c >> +++ b/drivers/staging/comedi/drivers/daqboard2000.c [snip] >> @@ -315,10 +313,6 @@ static void setup_sampling(struct comedi_device *dev, int chan, int gain) >> word3 = 0; >> break; >> } >> -/* >> - dev->eeprom.correctionDACSE[i][j][k].offset = 0x800; >> - dev->eeprom.correctionDACSE[i][j][k].gain = 0xc00; >> -*/ >> /* These should be read from EEPROM */ >> word2 |= 0x0800; >> word3 |= 0xc000; > > It might be a good idea to add a comment about the magic 0x0800 and 0xc000 values: > >> word2 |= 0x0800; /* offset */ >> word3 |= 0xc000; /* gain */ Fair enough. > Wish I could find a register map for this board. I sent an email to Measurement Computing > to see if one is available. I think the board was made by IOTech and added to Measurement Computing's catalog, and the Windows driver appears to have been done by IOTech too. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-