diff for duplicates of <573CB6ED.6090803@redhat.com> diff --git a/a/1.txt b/N1/1.txt index 745ad1d..1c765fe 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -49,7 +49,7 @@ On 18.05.2016 12:53, Thomas Huth wrote: >>>>>>>>>>>> case 0: >>>>>>>>>>>> - emulated = EMULATE_FAIL; >>>>>>>>>>>> if ((kvmppc_get_msr(vcpu) & MSR_LE) && ->>>>>>>>>>>> (inst = swab32(inst_sc))) { +>>>>>>>>>>>> (inst == swab32(inst_sc))) { >>>>>>>>>>>> /* >>>>>>>>>>>> @@ -112,6 +111,9 @@ int kvmppc_core_emulate_op_pr(struct kvm_run >>>>>>>>>>>> *run, @@ -166,12 +166,12 @@ On 18.05.2016 12:53, Thomas Huth wrote: > But when you look at the end of kvmppc_emulate_instruction(), you > can see that the interrupt has also already been injected there: > -> if (emulated = EMULATE_FAIL) { +> if (emulated == EMULATE_FAIL) { > emulated = vcpu->kvm->arch.kvm_ops->emulate_op(run, vcpu, inst, > &advance); -> if (emulated = EMULATE_AGAIN) { +> if (emulated == EMULATE_AGAIN) { > advance = 0; -> } else if (emulated = EMULATE_FAIL) { +> } else if (emulated == EMULATE_FAIL) { > advance = 0; > printk(KERN_ERR "Couldn't emulate instruction 0x%08x " > "(op %d xop %d)\n", inst, get_op(inst), get_xop(inst)); diff --git a/a/content_digest b/N1/content_digest index 17c7e28..9e782d8 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -12,7 +12,7 @@ "ref\0573C49C7.1060804@redhat.com\0" "From\0Thomas Huth <thuth@redhat.com>\0" "Subject\0Re: [PATCH] kvm-pr: manage illegal instructions\0" - "Date\0Wed, 18 May 2016 18:39:41 +0000\0" + "Date\0Wed, 18 May 2016 20:39:41 +0200\0" "To\0Laurent Vivier <lvivier@redhat.com>" " Alexander Graf <agraf@suse.de>\0" "Cc\0kvm@vger.kernel.org" @@ -77,7 +77,7 @@ ">>>>>>>>>>>> case 0:\n" ">>>>>>>>>>>> - emulated = EMULATE_FAIL;\n" ">>>>>>>>>>>> if ((kvmppc_get_msr(vcpu) & MSR_LE) &&\n" - ">>>>>>>>>>>> (inst = swab32(inst_sc))) {\n" + ">>>>>>>>>>>> (inst == swab32(inst_sc))) {\n" ">>>>>>>>>>>> /*\n" ">>>>>>>>>>>> @@ -112,6 +111,9 @@ int kvmppc_core_emulate_op_pr(struct kvm_run\n" ">>>>>>>>>>>> *run,\n" @@ -194,12 +194,12 @@ "> But when you look at the end of kvmppc_emulate_instruction(), you\n" "> can see that the interrupt has also already been injected there:\n" "> \n" - "> \tif (emulated = EMULATE_FAIL) {\n" + "> \tif (emulated == EMULATE_FAIL) {\n" "> \t\temulated = vcpu->kvm->arch.kvm_ops->emulate_op(run, vcpu, inst,\n" "> \t\t\t\t\t\t\t &advance);\n" - "> \t\tif (emulated = EMULATE_AGAIN) {\n" + "> \t\tif (emulated == EMULATE_AGAIN) {\n" "> \t\t\tadvance = 0;\n" - "> \t\t} else if (emulated = EMULATE_FAIL) {\n" + "> \t\t} else if (emulated == EMULATE_FAIL) {\n" "> \t\t\tadvance = 0;\n" "> \t\t\tprintk(KERN_ERR \"Couldn't emulate instruction 0x%08x \"\n" "> \t\t\t \"(op %d xop %d)\\n\", inst, get_op(inst), get_xop(inst));\n" @@ -220,4 +220,4 @@ "\n" Thomas -8543e2ae67f92207b9a9aa20f7d252fec23a749e671d40c5066e73a8d3678422 +1b609d11ac56c48b5c6fd8fb9271f4e63fcaac5a7f47b9d0a341f8e31312996c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.