From: Martin Kelly <martin@surround.io>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] Config.in: add -Og option
Date: Wed, 18 May 2016 13:06:20 -0700 [thread overview]
Message-ID: <573CCB3C.1040703@surround.io> (raw)
In-Reply-To: <7e07c970-b00e-f605-7192-3152d53885e1@mind.be>
On 05/18/2016 12:52 PM, Arnout Vandecappelle wrote:
> On 05/17/16 01:55, Martin Kelly wrote:
>> -Og (introduced in GCC 4.8) lets you optimize for debugging experience,
>> which can be useful for when you want optimized code that is nonetheless
>> debuggable.
>>
>> Signed-off-by: Martin Kelly <martin@surround.io>
>> ---
>> Changes based on feedback:
>> - select --> depends on
>> - Reworded help text
>> - Wrapped text to 72 lines
>
> Well, actually you didn't: you just copied my text, which I
> incorrectly wrapped at 78 columns instead of 72...
>
You may have wrapped to 78, but I rewrapped it to 72 columns, so I think
the patch I sent is correctly wrapped.
>> ---
>>
>> Config.in | 10 ++++++++++
>> package/Makefile.in | 3 +++
>> 2 files changed, 13 insertions(+)
>>
>> diff --git a/Config.in b/Config.in
>> index 9bc8e51..3fe6b7a 100644
>> --- a/Config.in
>> +++ b/Config.in
>> @@ -510,6 +510,16 @@ config BR2_OPTIMIZE_3
>> and also turns on the -finline-functions, -funswitch-loops and
>> -fgcse-after-reload options.
>>
>> +config BR2_OPTIMIZE_g
>
> I didn't notice this the first time: config options should be all
> capitals, like BR2_OPTIMIZE_S (for the -Os option).
>
I will change this and send a revised patch. Note that there are
currently several config options that are not all capital (e.g.
BR2_STRIP_strip), but perhaps those should change too.
next prev parent reply other threads:[~2016-05-18 20:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 23:55 [Buildroot] [PATCH v2] Config.in: add -Og option Martin Kelly
2016-05-18 19:52 ` Arnout Vandecappelle
2016-05-18 20:06 ` Martin Kelly [this message]
2016-05-18 21:51 ` Thomas Petazzoni
2016-05-18 22:00 ` Arnout Vandecappelle
2016-05-18 22:13 ` Martin Kelly
2016-05-18 22:16 ` Martin Kelly
2016-05-18 22:18 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573CCB3C.1040703@surround.io \
--to=martin@surround.io \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.