From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail5.wrs.com (mail5.windriver.com [192.103.53.11]) by mail.openembedded.org (Postfix) with ESMTP id E719D60670 for ; Thu, 19 May 2016 01:37:05 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail5.wrs.com (8.15.2/8.15.2) with ESMTPS id u4J1b3gI020322 (version=TLSv1 cipher=AES128-SHA bits=128 verify=OK); Wed, 18 May 2016 18:37:04 -0700 Received: from [128.224.162.159] (128.224.162.159) by ALA-HCA.corp.ad.wrs.com (147.11.189.40) with Microsoft SMTP Server id 14.3.248.2; Wed, 18 May 2016 18:37:02 -0700 To: References: <1462930752-234960-1-git-send-email-hongxu.jia@windriver.com> <573B38A0.9020806@windriver.com> <20160517153542.GC2559@jama> From: Hongxu Jia Message-ID: <573D18AC.6020203@windriver.com> Date: Thu, 19 May 2016 09:36:44 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160517153542.GC2559@jama> X-Content-Filtered-By: Mailman/MimeDel 2.1.12 Cc: koen.kooi@linaro.org Subject: Re: [PATCH V6] efivar: fix unknown option while gold linker used X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 May 2016 01:37:06 -0000 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit On 05/17/2016 11:35 PM, Martin Jansa wrote: > On Tue, May 17, 2016 at 11:28:32PM +0800, Hongxu Jia wrote: >> Ping Martin, >> >> Could you apply the V6? It should be ok with gold linker > I think it's already in master-next and will be merged after next round > of world builds. > Many thanks //Hongxu >> //Hongxu >> >> On 05/11/2016 09:39 AM, Hongxu Jia wrote: >>> - Use '-fPIC' to replace 'PIC'; >>> >>> - Use 'pie' to replace 'PIE' >>> >>> - Remove unknown '--add-needed' >>> >>> Signed-off-by: Hongxu Jia >>> --- >>> .../0004-fix-unknow-option-for-gold-linker.patch | 38 ++++++++++++++++++++++ >>> meta-oe/recipes-extended/efivar/efivar_0.23.bb | 1 + >>> 2 files changed, 39 insertions(+) >>> create mode 100644 meta-oe/recipes-extended/efivar/efivar/0004-fix-unknow-option-for-gold-linker.patch >>> >>> diff --git a/meta-oe/recipes-extended/efivar/efivar/0004-fix-unknow-option-for-gold-linker.patch b/meta-oe/recipes-extended/efivar/efivar/0004-fix-unknow-option-for-gold-linker.patch >>> new file mode 100644 >>> index 0000000..5d50c19 >>> --- /dev/null >>> +++ b/meta-oe/recipes-extended/efivar/efivar/0004-fix-unknow-option-for-gold-linker.patch >>> @@ -0,0 +1,38 @@ >>> +From b3d35e7dd27a755df5acbe050837885914dbb28b Mon Sep 17 00:00:00 2001 >>> +From: Hongxu Jia >>> +Date: Tue, 10 May 2016 11:34:50 -0400 >>> +Subject: [PATCH] fix unknow option for gold linker >>> + >>> +- Revert the following patch, since oe-core work with gcc 5 >>> +... >>> +commit 3055a3797f16693dfdd855fa68bc57fd900dc408 >>> +Author: Peter Jones >>> +Date: Mon Feb 15 14:15:40 2016 -0500 >>> + >>> + Make gcc.specs work with gcc 6 / binutils 2.26 >>> + >>> + Apparently binutils 2.26 gets real picky about "ld -PIC" vs "ld -fPIC". >>> + >>> + Signed-off-by: Peter Jones >>> +... >>> + >>> +- Remove unknown option '--add-needed' >>> + >>> +Signed-off-by: Hongxu Jia >>> +--- >>> + gcc.specs | 2 +- >>> + 1 file changed, 1 insertion(+), 1 deletion(-) >>> + >>> +diff --git a/gcc.specs b/gcc.specs >>> +index 24fabc2..5b0fdef 100644 >>> +--- a/gcc.specs >>> ++++ b/gcc.specs >>> +@@ -14,4 +14,4 @@ >>> + + %{!shared:%{!static:%{!r:-pie}}} %{static:-Wl,-no-fatal-warnings -Wl,-static -static -Wl,-z,relro,-z,now} >>> + >>> + *link: >>> +-+ %{!static:--fatal-warnings} --no-undefined-version --no-allow-shlib-undefined --add-needed -z now --build-id %{!static:%{!shared:-PIE}} %{shared:-z relro -PIC} %{static:%>> +++ %{!static:--fatal-warnings} --no-undefined-version --no-allow-shlib-undefined -z now --build-id %{!static:%{!shared:-pie}} %{shared:-z relro -fPIC} %{static:%>> +-- >>> +2.8.1 >>> + >>> diff --git a/meta-oe/recipes-extended/efivar/efivar_0.23.bb b/meta-oe/recipes-extended/efivar/efivar_0.23.bb >>> index 9c47461..6e9a51f 100644 >>> --- a/meta-oe/recipes-extended/efivar/efivar_0.23.bb >>> +++ b/meta-oe/recipes-extended/efivar/efivar_0.23.bb >>> @@ -12,6 +12,7 @@ SRC_URI = "git://github.com/rhinstaller/efivar.git" >>> SRC_URI_append_class-target = " file://0001-efivar-fix-for-cross-compile.patch \ >>> file://0002-disable-static-build.patch \ >>> file://0003-efivar-fix-for-cross-compile.patch \ >>> + file://0004-fix-unknow-option-for-gold-linker.patch \ >>> " >>> >>> S = "${WORKDIR}/git" > >