From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:36615 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752061AbcESGov (ORCPT ); Thu, 19 May 2016 02:44:51 -0400 Received: by mail-wm0-f65.google.com with SMTP id w143so18267609wmw.3 for ; Wed, 18 May 2016 23:44:50 -0700 (PDT) Subject: Re: [patch added to 3.12-stable] netem: Segment GSO packets on enqueue To: Eric Dumazet References: <1463582671-14713-1-git-send-email-jslaby@suse.cz> <1463582671-14713-19-git-send-email-jslaby@suse.cz> <1463583286.18194.116.camel@edumazet-glaptop3.roam.corp.google.com> <573C8336.9020507@suse.cz> <1463587496.18194.132.camel@edumazet-glaptop3.roam.corp.google.com> Cc: stable@vger.kernel.org, Neil Horman , Jamal Hadi Salim , "David S. Miller" , netem@lists.linux-foundation.org, stephen@networkplumber.org From: Jiri Slaby Message-ID: <573D60DF.20407@suse.cz> Date: Thu, 19 May 2016 08:44:47 +0200 MIME-Version: 1.0 In-Reply-To: <1463587496.18194.132.camel@edumazet-glaptop3.roam.corp.google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 05/18/2016, 06:04 PM, Eric Dumazet wrote: > On Wed, 2016-05-18 at 16:59 +0200, Jiri Slaby wrote: >> On 05/18/2016, 04:54 PM, Eric Dumazet wrote: > >>> ... But qdisc_tree_reduce_backlog() was not there in 3.12 >> >> Yeah, but I pulled the series from net_41 including the >> qdisc_tree_reduce_backlog backport. > > > Only for this backport ? Seems risky. > > I would have use qdisc_tree_decrease_qlen(sch, 1 - nb); here. Hmm, this looks sensible, indeed. Now I am thinking if there was other reason to backport the machinery to 4.1-stable? >>>> + if (nb > 1) >>>> + qdisc_tree_reduce_backlog(sch, 1 - nb, prev_len - len); >>>> + } >>>> return NET_XMIT_SUCCESS; >>>> } >> >> thanks, -- js suse labs