From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754494AbcESKCZ (ORCPT ); Thu, 19 May 2016 06:02:25 -0400 Received: from smtp89.iad3a.emailsrvr.com ([173.203.187.89]:37117 "EHLO smtp89.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754475AbcESKCY (ORCPT ); Thu, 19 May 2016 06:02:24 -0400 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH v2 00/14] staging: comedi: daqboard2000: checkpatch clean-ups To: devel@driverdev.osuosl.org References: <1463478773-5916-1-git-send-email-abbotti@mev.co.uk> <1463575029-12089-1-git-send-email-abbotti@mev.co.uk> Cc: Greg Kroah-Hartman , H Hartley Sweeten , linux-kernel@vger.kernel.org From: Ian Abbott Message-ID: <573D8F2C.4020404@mev.co.uk> Date: Thu, 19 May 2016 11:02:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <1463575029-12089-1-git-send-email-abbotti@mev.co.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/05/16 13:36, Ian Abbott wrote: > Patches 03 and 06 have checkpatch warnings themselves about CamelCase > issues, but they are not "new" issues, and are resolved by the later > patches in the series. > > 01) staging: comedi: daqboard2000: remove commented out code > 02) staging: comedi: daqboard2000: use usual block comment style > 03) staging: comedi: daqboard2000: CHECK: spaces preferred around that > '*' > 04) staging: comedi: daqboard2000: add blank line after struct > declaration > 05) staging: comedi: daqboard2000: rename serial EEPROM register macros > 06) staging: comedi: daqboard2000: rename register offset macros > 07) staging: comedi: daqboard2000: rename acquisition control register > macros > 08) staging: comedi: daqboard2000: rename acq status register macros > 09) staging: comedi: daqboard2000: redo DAC control register macros > 10) staging: comedi: daqboard2000: redo DAC status macros and fix busy > 11) staging: comedi: daqboard2000: rename trigger control register > macros > 12) staging: comedi: daqboard2000: rename reference DACs register macros > 13) staging: comedi: daqboard2000: rename CamelCase functions > 14) staging: comedi: daqboard2000: prefer usleep_range() > > v2: Incorporate suggestions by H Hartley Sweeten, adding a couple of > comments in patch 01, changing a prefix from `DAQBOARD2000_` to `DB2K_` > in patches 05 onwards, and changing a `udelay(10)` to `usleep_range(10, > 20)` in patch 14. > > drivers/staging/comedi/drivers/daqboard2000.c | 380 +++++++++++++------------- > 1 file changed, 189 insertions(+), 191 deletions(-) > I posted a v3 of patches 06 and 12, following Hartley's comments: [PATCH v3 06/14] staging: comedi: daqboard2000: rename register offset macros [PATCH v3 12/14] staging: comedi: daqboard2000: rename reference DACs register macros I can repost it as a full series if necessary. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-