All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: "David Miller" <davem@davemloft.net>,
	"Linux Kernel Network Developers" <netdev@vger.kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	nbd@nbd.name, baronchon@n7mm.org,
	"Alexander Duyck" <alexander.duyck@gmail.com>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"Eric Dumazet" <eric.dumazet@gmail.com>,
	"Jiří Pírko" <jiri@resnulli.us>,
	"Alexei Starovoitov" <alexei.starovoitov@gmail.com>
Subject: Re: [net-next RFC 1/1] net sched actions: introduce timestamp for first time used
Date: Thu, 19 May 2016 07:54:08 -0400	[thread overview]
Message-ID: <573DA960.8070102@mojatatu.com> (raw)
In-Reply-To: <CAM_iQpWXgncANS5MrBzrZiEVSbGzNptrAjisg_K2NTA-PsAMKg@mail.gmail.com>

On 16-05-18 01:17 PM, Cong Wang wrote:
> On Tue, May 17, 2016 at 4:38 PM, Jamal Hadi Salim <jhs@mojatatu.com> wrote:
>> diff --git a/net/sched/act_bpf.c b/net/sched/act_bpf.c
>> index 014f9a6..f581e01 100644
>> --- a/net/sched/act_bpf.c
>> +++ b/net/sched/act_bpf.c
>> @@ -156,6 +156,7 @@ static int tcf_bpf_dump(struct sk_buff *skb, struct tc_action *act,
>>
>>          tm.install = jiffies_to_clock_t(jiffies - prog->tcf_tm.install);
>>          tm.lastuse = jiffies_to_clock_t(jiffies - prog->tcf_tm.lastuse);
>> +       tm.firstuse = jiffies_to_clock_t(jiffies - prog->tcf_tm.firstuse);
>>          tm.expires = jiffies_to_clock_t(prog->tcf_tm.expires);
>
>
> I think it is the time to add a wrapper for these tm.XX =
> jiffies_to_clock_t(XXX).
>

Agreed. Will send a patch.
Actually I will resend the firstuse as well without RFC tag
and the wrapper one as separate patch.

cheers,
jamal

  reply	other threads:[~2016-05-19 11:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-17 23:38 [net-next RFC 1/1] net sched actions: introduce timestamp for first time used Jamal Hadi Salim
2016-05-18 17:17 ` Cong Wang
2016-05-19 11:54   ` Jamal Hadi Salim [this message]
2016-05-19 12:15     ` Jamal Hadi Salim
2016-05-19 16:38       ` Cong Wang
2016-05-20  5:16         ` Cong Wang
2016-05-22 16:32           ` Jamal Hadi Salim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=573DA960.8070102@mojatatu.com \
    --to=jhs@mojatatu.com \
    --cc=alexander.duyck@gmail.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=baronchon@n7mm.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jiri@resnulli.us \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.