From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH] amdgpu/uvd: use kmemdup Date: Thu, 19 May 2016 14:08:43 +0200 Message-ID: <573DACCB.5030604@amd.com> References: <1463656317-13828-1-git-send-email-falakreyaz@gmail.com> <573DA0F2.2020503@amd.com> <20160519114921.GA14314@kp> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0082.outbound.protection.outlook.com [65.55.169.82]) by gabe.freedesktop.org (Postfix) with ESMTPS id 53EA96E98D for ; Thu, 19 May 2016 12:09:06 +0000 (UTC) In-Reply-To: <20160519114921.GA14314@kp> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Muhammad Falak R Wani Cc: Jammy Zhou , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sonny Jiang , Alex Deucher , Leo Liu List-Id: dri-devel@lists.freedesktop.org QW0gMTkuMDUuMjAxNiB1bSAxMzo0OSBzY2hyaWViIE11aGFtbWFkIEZhbGFrIFIgV2FuaToKPiBP biBUaHUsIE1heSAxOSwgMjAxNiBhdCAwMToxODoxMFBNICswMjAwLCBDaHJpc3RpYW4gS8O2bmln IHdyb3RlOgo+PiBBbSAxOS4wNS4yMDE2IHVtIDEzOjExIHNjaHJpZWIgTXVoYW1tYWQgRmFsYWsg UiBXYW5pOgo+Pj4gVXNlIGttZW1kdXAgd2hlbiBzb21lIG90aGVyIGJ1ZmZlciBpcyBpbW1lZGlh dGVseSBjb3BpZWQgaW50byBhbGxvY2F0ZWQKPj4+IHJlZ2lvbi4gSXQgcmVwbGFjZXMgY2FsbCB0 byBhbGxvY2F0aW9uIGZvbGxvd2VkIGJ5IG1lbWNweSwgYnkgYSBzaW5nbGUKPj4+IGNhbGwgdG8g a21lbWR1cC4KPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBNdWhhbW1hZCBGYWxhayBSIFdhbmkgPGZh bGFrcmV5YXpAZ21haWwuY29tPgo+PiBOQUssIGFjdHVhbGx5IHVzaW5nIG1lbWNweSgpIGlzIHdy b25nIGluIHRoZSBmaXJzdCBwbGFjZS4KPj4KPj4gVGhlIFVWRCBCTyBpcyBpbiBWUkFNIHNvIHRo ZSBwb2ludGVyIGlzIHBvaW50aW5nIHRvIElPIG1lbW9yeSBoZXJlLAo+PiBzbyB0aGlzIHNob3Vs ZCBiZSBtZW1jcHlfZnJvbWlvKCkgaW5zdGVhZCBvZiBtZW1jcHkoKS4KPj4KPj4gQ2hyaXN0aWFu Lgo+Pgo+IFNob3VsZCBJIHNlbmQgVjIgd2l0aCB0aGUgcmVxdWlyZWQgY2hhbmdlcywgYW5kIEkg aGFkIGEgcXVlcnksCgpJIGNhbiB0YWtlIGNhcmUgb2YgZml4aW5nIHRoaXMuCgo+IElmIG1lbWNw eSB3YXMgd3JvbmcsIGRpZCBpdCBzdGlsbCB3b3JrIG9yIGl0IGp1c3QgZ290IHVuLW5vdGljZWQg PwoKQm90aCwgb24gWDg2IG1lbWNweSBmcm9tIElPIG1lbW9yeSB3b3JrcyBmaW5lLiBPbmx5IG9u IG90aGVyIAphcmNoaXRlY3R1cmVzIHlvdSBydW4gaW50byBwcm9ibGVtcyB3aXRoIHRoYXQuCgpS ZWdhcmRzLApDaHJpc3RpYW4uCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932260AbcESMJK (ORCPT ); Thu, 19 May 2016 08:09:10 -0400 Received: from mail-bl2on0096.outbound.protection.outlook.com ([65.55.169.96]:4328 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932140AbcESMJI (ORCPT ); Thu, 19 May 2016 08:09:08 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH] amdgpu/uvd: use kmemdup To: Muhammad Falak R Wani References: <1463656317-13828-1-git-send-email-falakreyaz@gmail.com> <573DA0F2.2020503@amd.com> <20160519114921.GA14314@kp> CC: David Airlie , Alex Deucher , Chunming Zhou , Jammy Zhou , Leo Liu , Sonny Jiang , , From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <573DACCB.5030604@amd.com> Date: Thu, 19 May 2016 14:08:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160519114921.GA14314@kp> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1250:ae81:e06e:5e9b:4940:a9d7] X-ClientProxiedBy: HE1PR02CA0081.eurprd02.prod.outlook.com (10.163.170.49) To DM2PR12MB0140.namprd12.prod.outlook.com (10.161.145.156) X-MS-Office365-Filtering-Correlation-Id: 6c654927-21f7-490f-29fe-08d37fde5ee9 X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0140;2:2OkeLTE7jEdsJLoOr5N9qSoO/ftBkt2DkzkyF1tWzCcA6Cg/ghtLCVC1TprQhhlF0bipJCj86vMBrZNMPWkGqHnz92uqduHuIfgtY9a/XoCa7GCrviPcc5o1AQp8z/hm4RwIDl5ES8TU5cF5LsQ9EoM5Ywc5Rp//mYobgBxhKi19UTfAat1NC1Tu+iHLM1ZT;3:BQizskvKgoJiU9v018WwhCPUxBuopGsHGK2UqPv3fQtzNIsYqRlYEEGtFAfiiZRtT1wstgwsj1XYdL1NELJ82nVX3wxHOJ9mQRH2KLRBnxNBHSgY5c/w7DEVNNzBUMvA X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR12MB0140; X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0140;25:4ONBqR7EqQ48uAXmNa9G1haCeyAtxKLsnZWyJiavH8lVP17JcISohtVEtxG8LMoj+pwh3hByi220YPskZD9BPz1FIBqMCKc0ROUeq4eLc7TUkj/vFV7gaiuy2+8MpUHaZ8h3dTRDiBngVsnSN3xhz11pkeB/vUyny7L8XR0pddpMK19tCbQgLftzL0qWYymRBEVDnD2QQ+shJq42FuwcYTs3oXv/6HGchkeqg0H4UtEqlWz1R5nNfVUGtex3QxSQ1C/0ezkX/uNrpPNhfQAKo8AGCQlA33AI+IvgXUEaILJOcNkw3LfTTRLHewVMATYZiFtsFMiFmTWN5jWEaH3kSZeD7WopnI9rMrUcm84tvESkt5rjo+iTsPDGTeZEtkftkib9NcpNhC59wt8GtLENWN2bTei8lpddqbx1YlC0xNf+cTd1x7bJiVzqLaqG+7nnX3w1xjRJaIXAX3CIBRuRH5go+CQ9N78W5VoQat4mfrqlE/rKTj/BuHGF34xnNp/1oG6MnQgooqlt/8sK7PLa4dCrJ27jPjJst8g1ZCUnFtfPuqIg8NwIo4rJRleXsb9v7msqR36/Yy2FiL2TrETz4yRTHWBZZLUbKvbWKcZA7Ns90Ngn8sm2gkr4h3kR0IWyloLzCCz9Ufd58OiA9tIsCd0QtBXBLjeDf7jhpcWRgmv4jopFlVRTOEYQBh/cyS4l4nZxw0ib4niHhh84MTXLlQYbn8895EvpPXbaHRakwU8VbOl4oZRp3OSYLJbK2GSl X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0140;20:2t1He55HX17fxUdlte/DTRcY20txk5ZPj2u4l/Qbr/WLPo2pyFYMABCLsHiWOP29TFsl2CZf/sKxTC5EuWr0wqfJhLABA5gwmmkVoVSY2AjmVHGtx7R27njJ+L/ny1lo+0MRywpxbCHvtNABAatmrYZ5ODoh4IUl+B+3i0rpUAc3CbKUVJsJHvU3C6lJSuBrukzoXIXoD2pNP+VSW0r6wzTlESMHAEueT1KFdA2UYJZLAF91FGjbIb4QseciKlQd8hoGD0AihJMpQ+eXEji5UVhPkKoBoEeeOzrpaws1NLaUwdFooGI3DwZPooxysSYwRSPpYOZYQUmR5fxRXGOtGkFfqjJPeErsDug0P1w3THiLfgW19PE+lrRFg61Cp3c/sS+ljKB6OMVyuqgPqvdW+oO/9ZOR0ThYKCsE9X2uq4V1abwKQC89QDfrDdhVG1AJROLHIIa53gkoCJXR2gAWEJLlaEbwvU2Qe6U/g7FgsOtX85RzokoFsK5TzZMQWS0w;4:SwyEBdwLBLBCzACWmkhush36n6kz1cfqUVZalRq79MpobIwCXubKw5pyLWtrF9onPhedfJefRIaF8G3isO3I4fvI/+dWe4WXoCSu5EGlT3KSPitp/2+UZ08A6tlzfNSlJqmHQiyVVeg4CYx12NS4vynMlBvDzIcZhzbQfpogH0iw8UMGVdsRsbO0zUtK/eVsKQURdtnwQUiYj5G54HPYWGd/iQur0kKfuQtrZFFdj8Z7OipOkH7pWBVOcOCp1SETckuzdt4cclSIJyntToxiT0rUC5H/owF7pJOuzTp3fsQxvbfO7X6S3NJM9P31T7LDxquvXQaW+1jVuiWr8ilKckbTbmz69elS+FGDiOPxnMyhof/GRCNVoY4SFv6f4Pfi+pHUuLchp93y9m5leYBX2A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:DM2PR12MB0140;BCL:0;PCL:0;RULEID:;SRVR:DM2PR12MB0140; X-Forefront-PRVS: 094700CA91 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(43544003)(24454002)(42186005)(19580395003)(59896002)(5004730100002)(6116002)(19580405001)(23746002)(83506001)(2870700001)(4001350100001)(86362001)(33656002)(2950100001)(1411001)(65806001)(5008740100001)(50986999)(65816999)(54356999)(76176999)(87266999)(92566002)(64126003)(586003)(8676002)(81166006)(77096005)(110136002)(36756003)(47776003)(2906002)(50466002)(189998001)(4326007)(3826002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR12MB0140;H:[IPv6:2a02:908:1250:ae81:e06e:5e9b:4940:a9d7];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DM2PR12MB0140;23:HUV0R1DxFvliRoG0A9eey0BJc39dczSD3ZgaP?= =?Windows-1252?Q?324ely9butjvX59rHtbfckk61ebi1xpMQxUpJe2snOG99JzQLts0N6ka?= =?Windows-1252?Q?gkdNZf6EgTaTkVypQlUZis4ek0a/hvyJNS7MwXpu3nq35hktiYlJYsPp?= =?Windows-1252?Q?T51uIAia/+PlAxSfD4oBwE5y/nQPTFf4T8nKHJrQwiN4dgWykiplroUZ?= =?Windows-1252?Q?LNbmA0UdcOQxcF9eBENWXJ5w4+LYqlkkHkMmOndEXfk8hQfd46TTMOJy?= =?Windows-1252?Q?s/CzhcqTCX9VkIpdFQ01zSHuzgO4BKW5PA4ToplGso5UD0KS9UVJAV7x?= =?Windows-1252?Q?7Gtsx0ey+ovgGa33LFENr4Ezy4STvkAag2g6Nov8hRpER1KB9oRgWqM1?= =?Windows-1252?Q?r+tQ9ZAbl2ndzG2jWsjIvBrTUiovEOM4AvxYHnnL1RV5xxwMaORunXbw?= =?Windows-1252?Q?23WGHwDTewFejs3nZc9u0vG6+06oiibI2anlNBKVWJPyHc/3A2C9qepV?= =?Windows-1252?Q?XN7+wabGEtwEnatCfqAcIdo//QwIuEDVvgB2nTJB0zSVmrpsXV10OgkH?= =?Windows-1252?Q?otZTfDL3v79/ic+cjcIEWihQJXI5rjJlVBpYGvDrmHYaXCs4WIzB/Pg1?= =?Windows-1252?Q?m1sYsJJXo9A7JVIBSMY9rzp6WephRjac+nUPOYpr1uvk//oiTC1JgP/L?= =?Windows-1252?Q?zFQ/J4Kyo200si93FTssLKfHf+7YZC+BJujVvHbXtL0Pj+KemyGyJnKv?= =?Windows-1252?Q?akomrVlQBvLvhwd/dADSG3iPPwiTAUhZTZoi2DxV84IN6i9BdBmXnir4?= =?Windows-1252?Q?BESL0J1YRfLV/9kW7BnNEM+XCPPnDvjM5RgZ2gbmhW9QI6k1h1t5Y36G?= =?Windows-1252?Q?DLE6vlNz5FwscY9ZjjWwL0Rm4YPqTOjZcRRaJITQf3t3g9ybP1J6V5hp?= =?Windows-1252?Q?sMveeSHH/cWhfmBBSAdxPKicoyjOjy7yjgdKhzbIp3Cx3b+4TbWzH8Y/?= =?Windows-1252?Q?ZIUSN/d0CqAm0W7HEo/rfjmy0Gu1nfrJkFdwlg43USRJtIcTUpMM4VHB?= =?Windows-1252?Q?R41t0RitjFWyWwiTu47PBTRyXLR+0Elg0cupwAf/+JWN7yV8PSvegLYV?= =?Windows-1252?B?UT09?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0140;5:RkatR6t9U5Bnafcx41Rqho4jS3Zth6b6xcSZgpLfuvAjDZNAyTpfzK7phLIZND8X8MYh7hnt7sI1+m2GU+7QtVkeOZifQnzI7ww0JxoC4Yce+Pq8lF7eU9QwYceJzGgRyJdPlKRfEF+2x12ZNywG8A==;24:ikSCJP7/Lu8yLFZukGpFMn2yBBkIzkNrv2JC2xgKWWyYv1JKQEfdx5DJhKHrCHaNtGq+H+XMG796DL+JICpl7vv9fGjU8eza345OghzAWo8=;7:o1vGRsoAGVAVzhQOHNkEGawA4CFuIWGw25IQuKW3WzptmrtsFaD5ifuiQPAsXwgMvOCiIkNJNeb/dFMzwtnsVQuqxGICHpFGruv4HIIAhFIwOduHCmfXTG7vXznlRX+FASPkAWMivZ5Qbk4KmrRfvLTqeMk4sLGBqulmYEC5DoA=;20:oT8zzojtgxpePMuYmLydhUGJ2SW3XKrIqZeMoVcH3HhdbzjHIQJ/aYISB93l4v8VYxRYLmQBzTheu2Pd6Xhp2HAL75IgUDp7GuAhCguv7y6FqdakcIjpFpe89F/1JWPpi85JzinIj+BMGgvDZyhRANT9LktusIRsZNHS/ZrX2evymWoPovj0R0lV4nJviQmEmGC1S/gx9wICApxjQ/4rx/CqMRNCQ0c/dMCG+y6p26Z2OFodR6+e5ZJKq9Lle8Sb X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2016 12:09:01.4771 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR12MB0140 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 19.05.2016 um 13:49 schrieb Muhammad Falak R Wani: > On Thu, May 19, 2016 at 01:18:10PM +0200, Christian König wrote: >> Am 19.05.2016 um 13:11 schrieb Muhammad Falak R Wani: >>> Use kmemdup when some other buffer is immediately copied into allocated >>> region. It replaces call to allocation followed by memcpy, by a single >>> call to kmemdup. >>> >>> Signed-off-by: Muhammad Falak R Wani >> NAK, actually using memcpy() is wrong in the first place. >> >> The UVD BO is in VRAM so the pointer is pointing to IO memory here, >> so this should be memcpy_fromio() instead of memcpy(). >> >> Christian. >> > Should I send V2 with the required changes, and I had a query, I can take care of fixing this. > If memcpy was wrong, did it still work or it just got un-noticed ? Both, on X86 memcpy from IO memory works fine. Only on other architectures you run into problems with that. Regards, Christian.