From mboxrd@z Thu Jan 1 00:00:00 1970 From: Caesar Wang Subject: Re: [PATCH 1/3] spi/rockchip: add rk3036/rk3228/rk3368 socs for spi document Date: Fri, 20 May 2016 00:04:07 +0800 Message-ID: <573DE3F7.6070300@rock-chips.com> References: <1463672824-15367-1-git-send-email-wxt@rock-chips.com> <3685935.dKdIbE8hXb@phil> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <3685935.dKdIbE8hXb@phil> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Heiko Stuebner Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Pawel Moll , Ian Campbell , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Mark Brown , Kumar Gala , Xu Jianqun , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-rockchip.vger.kernel.org CgrlnKggMjAxNuW5tDA15pyIMTnml6UgMjM6NTEsIEhlaWtvIFN0dWVibmVyIOWGmemBkzoKPiBB bSBEb25uZXJzdGFnLCAxOS4gTWFpIDIwMTYsIDIzOjQ3OjAyIHNjaHJpZWIgQ2Flc2FyIFdhbmc6 Cj4+IFdlIGhhZCBzdXBwb3J0ZWQgdGhlIHJrMzAzNi9yazMwNjYvcmszMTg4L3JrMzIyOC9yazMy ODgvcmszMzY4L3JrMzM5OQo+PiBmYW1pbHkgU29DcyBpbiBsaW51eCBrZXJuZWwuCj4+Cj4+IExl dCdzIGFkZCB0aGUgb3RoZXIgU29DcywgaW4gb3JkZXIgdG8gYSBiZXR0ZXIgdW5kZXJzdGFuZGlu ZyBmcm9tIHRoZQo+PiByb2NrY2hpcCBzcGkgZG9jdW1lbnQuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6 IENhZXNhciBXYW5nIDx3eHRAcm9jay1jaGlwcy5jb20+Cj4+IENjOiBSb2IgSGVycmluZyA8cm9i aCtkdEBrZXJuZWwub3JnPgo+PiBDYzogTWFyayBCcm93biA8YnJvb25pZUBrZXJuZWwub3JnPgo+ PiBDYzogSGVpa28gU3R1ZWJuZXIgPGhlaWtvQHNudGVjaC5kZT4KPj4gQ2M6IGxpbnV4LXJvY2tj aGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKPj4gLS0tCj4+Cj4+ICAgRG9jdW1lbnRhdGlvbi9kZXZp Y2V0cmVlL2JpbmRpbmdzL3NwaS9zcGktcm9ja2NoaXAudHh0IHwgMyArKysKPj4gICAxIGZpbGUg Y2hhbmdlZCwgMyBpbnNlcnRpb25zKCspCj4+Cj4+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3Mvc3BpL3NwaS1yb2NrY2hpcC50eHQKPj4gYi9Eb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3Mvc3BpL3NwaS1yb2NrY2hpcC50eHQgaW5kZXgKPj4gMWIx NGQ2OS4uMzA1YjU0MiAxMDA2NDQKPj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL3NwaS9zcGktcm9ja2NoaXAudHh0Cj4+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNl dHJlZS9iaW5kaW5ncy9zcGkvc3BpLXJvY2tjaGlwLnR4dAo+PiBAQCAtNiw5ICs2LDEyIEBAIGFu ZCBkaXNwbGF5IGNvbnRyb2xsZXJzIHVzaW5nIHRoZSBTUEkgY29tbXVuaWNhdGlvbgo+PiBpbnRl cmZhY2UuIFJlcXVpcmVkIFByb3BlcnRpZXM6Cj4+Cj4+ICAgLSBjb21wYXRpYmxlOiBzaG91bGQg YmUgb25lIG9mIHRoZSBmb2xsb3dpbmcuCj4+ICsgICAgInJvY2tjaGlwLHJrMzAzNi1zcGkiIGZv ciByazMwMzYuCj4gc2hvdWxkbid0IHRoZSByazMwMzYgYWxzbyBnZXQgdGhlIHJrMzA2NiBmYWxs YmFjay4gTG9va2luZyBhdCB0aGUgZHJpdmVyCj4gcGFydCAocGF0Y2gyKSB0aGUgcmszMDM2IHN0 aWxsIGlzIHRoZSBzYW1lIElQIGFzIGZvciBldmVyeSBvdGhlciBzb2MgaW4KPiBoZXJlLgoKWWVw LCB0aGUgc2FtZSBJUC4KCkRvIHlvdSB0aGluayB3ZSBzaG91bGQga2VlcCB0aGUgYmVsb3cgc3R5 bGU/CgoxKQoicm9ja2NoaXAscmszMDM2LXNwaSIsICJyb2NrY2hpcCxyazMwNjYtc3BpIiBmb3Ig cmszMDM2LgogICJyb2NrY2hpcCxyazMwNjYtc3BpIiBmb3IgcmszMDY2LgogICJyb2NrY2hpcCxy azMxODgtc3BpIiwgInJvY2tjaGlwLHJrMzA2Ni1zcGkiIGZvciByazMxODguCi4uLgoKb3IKMikK ICAicm9ja2NoaXAscmszMDY2LXNwaSIgZm9yIHJrMzA2Ni4KInJvY2tjaGlwLHJrMzAzNi1zcGki LCAicm9ja2NoaXAscmszMDY2LXNwaSIgZm9yIHJrMzAzNi4KICAicm9ja2NoaXAscmszMTg4LXNw aSIsICJyb2NrY2hpcCxyazMwNjYtc3BpIiBmb3IgcmszMTg4Ci4uCgpvcgozKQoicm9ja2NoaXAs IHJvY2tjaGlwLXNwaSIgZm9yIHJrMzAzNiByazMwNjYuLi4uLi4uCgpUaGluayBhYm91dCB0aGUg MSkgd2lsbCBiZSBnb29nZCBzZWxlY3QuCgotQ2Flc2FyCgo+PiAgICAgICAicm9ja2NoaXAscmsz MDY2LXNwaSIgZm9yIHJrMzA2Ni4KPj4gICAgICAgInJvY2tjaGlwLHJrMzE4OC1zcGkiLCAicm9j a2NoaXAscmszMDY2LXNwaSIgZm9yIHJrMzE4OC4KPj4gKyAgICAicm9ja2NoaXAscmszMjI4LXNw aSIsICJyb2NrY2hpcCxyazMwNjYtc3BpIiBmb3IgcmszMjI4Lgo+PiAgICAgICAicm9ja2NoaXAs cmszMjg4LXNwaSIsICJyb2NrY2hpcCxyazMwNjYtc3BpIiBmb3IgcmszMjg4Lgo+PiArICAgICJy b2NrY2hpcCxyazMzNjgtc3BpIiwgInJvY2tjaGlwLHJrMzA2Ni1zcGkiIGZvciByazMzNjguCj4+ ICAgICAgICJyb2NrY2hpcCxyazMzOTktc3BpIiwgInJvY2tjaGlwLHJrMzA2Ni1zcGkiIGZvciBy azMzOTkuCj4+ICAgLSByZWc6IHBoeXNpY2FsIGJhc2UgYWRkcmVzcyBvZiB0aGUgY29udHJvbGxl ciBhbmQgbGVuZ3RoIG9mIG1lbW9yeQo+PiBtYXBwZWQgcmVnaW9uLgo+Cj4KPgoKCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBt YWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: wxt@rock-chips.com (Caesar Wang) Date: Fri, 20 May 2016 00:04:07 +0800 Subject: [PATCH 1/3] spi/rockchip: add rk3036/rk3228/rk3368 socs for spi document In-Reply-To: <3685935.dKdIbE8hXb@phil> References: <1463672824-15367-1-git-send-email-wxt@rock-chips.com> <3685935.dKdIbE8hXb@phil> Message-ID: <573DE3F7.6070300@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org ? 2016?05?19? 23:51, Heiko Stuebner ??: > Am Donnerstag, 19. Mai 2016, 23:47:02 schrieb Caesar Wang: >> We had supported the rk3036/rk3066/rk3188/rk3228/rk3288/rk3368/rk3399 >> family SoCs in linux kernel. >> >> Let's add the other SoCs, in order to a better understanding from the >> rockchip spi document. >> >> Signed-off-by: Caesar Wang >> Cc: Rob Herring >> Cc: Mark Brown >> Cc: Heiko Stuebner >> Cc: linux-rockchip at lists.infradead.org >> --- >> >> Documentation/devicetree/bindings/spi/spi-rockchip.txt | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/spi/spi-rockchip.txt >> b/Documentation/devicetree/bindings/spi/spi-rockchip.txt index >> 1b14d69..305b542 100644 >> --- a/Documentation/devicetree/bindings/spi/spi-rockchip.txt >> +++ b/Documentation/devicetree/bindings/spi/spi-rockchip.txt >> @@ -6,9 +6,12 @@ and display controllers using the SPI communication >> interface. Required Properties: >> >> - compatible: should be one of the following. >> + "rockchip,rk3036-spi" for rk3036. > shouldn't the rk3036 also get the rk3066 fallback. Looking at the driver > part (patch2) the rk3036 still is the same IP as for every other soc in > here. Yep, the same IP. Do you think we should keep the below style? 1) "rockchip,rk3036-spi", "rockchip,rk3066-spi" for rk3036. "rockchip,rk3066-spi" for rk3066. "rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188. ... or 2) "rockchip,rk3066-spi" for rk3066. "rockchip,rk3036-spi", "rockchip,rk3066-spi" for rk3036. "rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188 .. or 3) "rockchip, rockchip-spi" for rk3036 rk3066....... Think about the 1) will be googd select. -Caesar >> "rockchip,rk3066-spi" for rk3066. >> "rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188. >> + "rockchip,rk3228-spi", "rockchip,rk3066-spi" for rk3228. >> "rockchip,rk3288-spi", "rockchip,rk3066-spi" for rk3288. >> + "rockchip,rk3368-spi", "rockchip,rk3066-spi" for rk3368. >> "rockchip,rk3399-spi", "rockchip,rk3066-spi" for rk3399. >> - reg: physical base address of the controller and length of memory >> mapped region. > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932613AbcESQKV (ORCPT ); Thu, 19 May 2016 12:10:21 -0400 Received: from regular2.263xmail.com ([211.157.152.5]:55475 "EHLO regular2.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754300AbcESQKT (ORCPT ); Thu, 19 May 2016 12:10:19 -0400 X-Greylist: delayed 341 seconds by postgrey-1.27 at vger.kernel.org; Thu, 19 May 2016 12:10:18 EDT X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: wxt@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 220.200.28.94 X-LOGIN-NAME: wxt@rock-chips.com X-UNIQUE-TAG: <90efc5cdee881d34632064a3a42747bf> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 1/3] spi/rockchip: add rk3036/rk3228/rk3368 socs for spi document To: Heiko Stuebner References: <1463672824-15367-1-git-send-email-wxt@rock-chips.com> <3685935.dKdIbE8hXb@phil> Cc: Mark Brown , linux-rockchip@lists.infradead.org, Rob Herring , devicetree@vger.kernel.org, Xu Jianqun , Kumar Gala , linux-kernel@vger.kernel.org, Ian Campbell , Pawel Moll , Mark Rutland , linux-arm-kernel@lists.infradead.org From: Caesar Wang Message-ID: <573DE3F7.6070300@rock-chips.com> Date: Fri, 20 May 2016 00:04:07 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <3685935.dKdIbE8hXb@phil> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2016年05月19日 23:51, Heiko Stuebner 写道: > Am Donnerstag, 19. Mai 2016, 23:47:02 schrieb Caesar Wang: >> We had supported the rk3036/rk3066/rk3188/rk3228/rk3288/rk3368/rk3399 >> family SoCs in linux kernel. >> >> Let's add the other SoCs, in order to a better understanding from the >> rockchip spi document. >> >> Signed-off-by: Caesar Wang >> Cc: Rob Herring >> Cc: Mark Brown >> Cc: Heiko Stuebner >> Cc: linux-rockchip@lists.infradead.org >> --- >> >> Documentation/devicetree/bindings/spi/spi-rockchip.txt | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/spi/spi-rockchip.txt >> b/Documentation/devicetree/bindings/spi/spi-rockchip.txt index >> 1b14d69..305b542 100644 >> --- a/Documentation/devicetree/bindings/spi/spi-rockchip.txt >> +++ b/Documentation/devicetree/bindings/spi/spi-rockchip.txt >> @@ -6,9 +6,12 @@ and display controllers using the SPI communication >> interface. Required Properties: >> >> - compatible: should be one of the following. >> + "rockchip,rk3036-spi" for rk3036. > shouldn't the rk3036 also get the rk3066 fallback. Looking at the driver > part (patch2) the rk3036 still is the same IP as for every other soc in > here. Yep, the same IP. Do you think we should keep the below style? 1) "rockchip,rk3036-spi", "rockchip,rk3066-spi" for rk3036. "rockchip,rk3066-spi" for rk3066. "rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188. ... or 2) "rockchip,rk3066-spi" for rk3066. "rockchip,rk3036-spi", "rockchip,rk3066-spi" for rk3036. "rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188 .. or 3) "rockchip, rockchip-spi" for rk3036 rk3066....... Think about the 1) will be googd select. -Caesar >> "rockchip,rk3066-spi" for rk3066. >> "rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188. >> + "rockchip,rk3228-spi", "rockchip,rk3066-spi" for rk3228. >> "rockchip,rk3288-spi", "rockchip,rk3066-spi" for rk3288. >> + "rockchip,rk3368-spi", "rockchip,rk3066-spi" for rk3368. >> "rockchip,rk3399-spi", "rockchip,rk3066-spi" for rk3399. >> - reg: physical base address of the controller and length of memory >> mapped region. > > >