From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932540AbcESRmf (ORCPT ); Thu, 19 May 2016 13:42:35 -0400 Received: from smtp73.ord1c.emailsrvr.com ([108.166.43.73]:50636 "EHLO smtp73.ord1c.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754342AbcESRme (ORCPT ); Thu, 19 May 2016 13:42:34 -0400 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH v3 06/14] staging: comedi: daqboard2000: rename register offset macros To: Hartley Sweeten , "devel@driverdev.osuosl.org" References: <1463575029-12089-7-git-send-email-abbotti@mev.co.uk> <1463651747-6734-1-git-send-email-abbotti@mev.co.uk> Cc: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" From: Ian Abbott Message-ID: <573DFB07.4020006@mev.co.uk> Date: Thu, 19 May 2016 18:42:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/05/16 17:49, Hartley Sweeten wrote: > On Thursday, May 19, 2016 2:56 AM, Ian Abbott wrote: >> Rename the macros defining register offsets to avoid CamelCase, and to >> use namespace associated with the driver. >> >> Signed-off-by: Ian Abbott >> Reviewed-by: H Hartley Sweeten >> --- >> Other CamelCase issues in this patch will be dealt with by later >> patches in the series. >> >> v2: Shortened prefix from `DAQBOARD2000_` to `DB2K_`. >> v3: Removed a space before tab that slipped in in v2. > > Ian, > > Your [PATCH v2 07/14: ...] does not apply after this one. > > It's probably better if Greg drops the previous patches and you > post a full series. I must be having a bad day! I'll repost it all as v4. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-