From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Kerr Date: Fri, 20 May 2016 01:21:58 +0000 Subject: Re: [PATCH] fbcon: warn on invalid cursor blink intervals Message-Id: <573E66B6.40109@ozlabs.org> List-Id: References: <1463510464-28124-1-git-send-email-ddaney.cavm@gmail.com> <20160517204912.GA29719@amd> <573DE2D0.1050402@caviumnetworks.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Scot Doyle , Tomi Valkeinen , Jean-Christophe Plagniol-Villard Cc: David Daney , Ming Lei , Dann Frazier , Peter Hurley , Pavel Machek , Jonathan Liu , Alistair Popple , Jean-Philippe Brucker , "Chintakuntla, Radha" , Greg Kroah-Hartman , Jiri Slaby , David Airlie , ddaney.cavm@gmail.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Hi Scot, > Two systems are locking on boot [1] because ops->cur_blink_jiffies > is set to zero from vc->vc_cur_blink_ms. > > Ignore such invalid intervals and log a warning. This prevents a lockup on AST BMC machines, but (as expected) generates a warning against the fbcon driver, which is a significantly better result. Tested-by: Jeremy Kerr [now to sort out the issue in the ast driver...] Cheers, Jeremy From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Kerr Subject: Re: [PATCH] fbcon: warn on invalid cursor blink intervals Date: Fri, 20 May 2016 09:21:58 +0800 Message-ID: <573E66B6.40109@ozlabs.org> References: <1463510464-28124-1-git-send-email-ddaney.cavm@gmail.com> <20160517204912.GA29719@amd> <573DE2D0.1050402@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: stable-owner@vger.kernel.org To: Scot Doyle , Tomi Valkeinen , Jean-Christophe Plagniol-Villard Cc: David Daney , Ming Lei , Dann Frazier , Peter Hurley , Pavel Machek , Jonathan Liu , Alistair Popple , Jean-Philippe Brucker , "Chintakuntla, Radha" , Greg Kroah-Hartman , Jiri Slaby , David Airlie , ddaney.cavm@gmail.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org Hi Scot, > Two systems are locking on boot [1] because ops->cur_blink_jiffies > is set to zero from vc->vc_cur_blink_ms. > > Ignore such invalid intervals and log a warning. This prevents a lockup on AST BMC machines, but (as expected) generates a warning against the fbcon driver, which is a significantly better result. Tested-by: Jeremy Kerr [now to sort out the issue in the ast driver...] Cheers, Jeremy