From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: Tony Makkiel <tony.makkiel@daqri.com>
Cc: linux-leds@vger.kernel.org
Subject: Re: Hardware blink and brightness
Date: Fri, 20 May 2016 09:25:02 +0200 [thread overview]
Message-ID: <573EBBCE.2030709@samsung.com> (raw)
In-Reply-To: <573DE268.3060900@daqri.com>
Hi Tony,
On 05/19/2016 05:57 PM, Tony Makkiel wrote:
> Hi,
> Is there any particular reason to stipulate, (hardware) blink should be turned off, when brightness is set to 0? Following is copied from "Documentation/leds/leds-class.txt"
>
> "Setting the brightness to zero with brightness_set() callback function
> should completely turn off the LED and cancel the previously programmed
> hardware blinking function, if any."
>
> The chip driver could also use other methods for the same, keeping brightness independent of blink.
>
> For example, delay_on/off
> delay_off=0 ==> blink off, led on.
> delay_on=0 ==> blink off, led off.
>
> Or am I overlooking something?
Setting brightness to zero not only disables blinking but also
any other active trigger. Besides, would it make sense to have
blinking enabled with brightness set to 0?
Anyway, we have to keep this interface as-is so as not to break
existing users of the LED API.
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2016-05-20 7:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 15:57 Hardware blink and brightness Tony Makkiel
2016-05-20 7:25 ` Jacek Anaszewski [this message]
2016-05-26 14:48 ` Tony Makkiel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573EBBCE.2030709@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=linux-leds@vger.kernel.org \
--cc=tony.makkiel@daqri.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.