From: Waiman Long <waiman.long@hpe.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: Jason Low <jason.low2@hpe.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, <linux-kernel@vger.kernel.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Terry Rudd <terry.rudd@hpe.com>,
Scott J Norton <scott.norton@hpe.com>,
Jason Low <jason.low2@hp.com>
Subject: Re: [PATCH] locking/mutex: Set and clear owner using WRITE_ONCE()
Date: Sat, 21 May 2016 00:09:30 -0400 [thread overview]
Message-ID: <573FDF7A.6090607@hpe.com> (raw)
In-Reply-To: <20160521010044.GC28231@linux-uzut.site>
On 05/20/2016 09:00 PM, Davidlohr Bueso wrote:
> On Fri, 20 May 2016, Waiman Long wrote:
>
>> I think mutex-debug.h also needs similar changes for completeness.
>
> Maybe, but given that with debug the wait_lock is unavoidable, doesn't
> this send the wrong message?
>
> Thanks,
> Davidlohr
You are right. Optimistic spinning is disabled when DEBUG_MUTEXES is
true. So WRITE_ONCE() is not really needed. However, I think we should
have at least a comment in mutex-debug.h as to why the owner field is
handled differently from mutex.h.
Cheers,
Longman
next prev parent reply other threads:[~2016-05-21 4:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 22:23 [PATCH] locking/mutex: Set and clear owner using WRITE_ONCE() Jason Low
2016-05-20 1:19 ` Davidlohr Bueso
2016-05-20 20:27 ` Waiman Long
2016-05-20 22:09 ` Jason Low
2016-05-21 1:00 ` Davidlohr Bueso
2016-05-21 4:09 ` Waiman Long [this message]
2016-05-23 20:40 ` Jason Low
2016-05-23 21:31 ` Davidlohr Bueso
2016-05-23 21:49 ` Jason Low
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573FDF7A.6090607@hpe.com \
--to=waiman.long@hpe.com \
--cc=dave@stgolabs.net \
--cc=jason.low2@hp.com \
--cc=jason.low2@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=scott.norton@hpe.com \
--cc=terry.rudd@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.