From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?P=E9ter?= Ujfalusi Subject: Re: [PATCH v4 11/18] input: Add initial support for TWL6040 vibrator Date: Fri, 17 Jun 2011 12:39:57 +0300 Message-ID: <5740779.B2nyl9oMW4@barack> References: <1307706876-4768-1-git-send-email-peter.ujfalusi@ti.com> <20110616120244.GA2611@htj.dyndns.org> <4306005.scnJ1lQX4P@barack> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from bear.ext.ti.com (bear.ext.ti.com [192.94.94.41]) by alsa0.perex.cz (Postfix) with ESMTP id 8AE282446D for ; Fri, 17 Jun 2011 10:35:52 +0200 (CEST) In-Reply-To: <4306005.scnJ1lQX4P@barack> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: alsa-devel@alsa-project.org Cc: Dmitry Torokhov , Samuel Ortiz , Tony Lindgren , Mark Brown , "linux-kernel@vger.kernel.org" , "linux-input@vger.kernel.org" , Tejun Heo , "Lopez Cruz, Misael" , "linux-omap@vger.kernel.org" , "Girdwood, Liam" List-Id: alsa-devel@alsa-project.org Hello Tejun, On Thursday 16 June 2011 16:06:00 Ujfalusi, Peter wrote: > > I suppose you meant alloc_workqueue()? :) > = > Oh, yes. I mean that. Just avoid another series... I have looked at the alloc_workqueue, and I'm not really sure what paramete= rs = should I use. #define create_singlethread_workqueue(name) \ alloc_workqueue((name), WQ_UNBOUND | WQ_MEM_RECLAIM, 1) I would use something like this instead of create_singlethread_workqueue: alloc_workqueue("twl6040-vibra", WQ_UNBOUND | WQ_MEM_RECLAIM | WQ_HIGHPRI, = 1); Is this correct? Thanks, P=E9ter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758040Ab1FQIgE (ORCPT ); Fri, 17 Jun 2011 04:36:04 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:55236 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756825Ab1FQIgA convert rfc822-to-8bit (ORCPT ); Fri, 17 Jun 2011 04:36:00 -0400 From: =?ISO-8859-1?Q?P=E9ter?= Ujfalusi To: CC: Tejun Heo , Mark Brown , Samuel Ortiz , Tony Lindgren , Dmitry Torokhov , "linux-kernel@vger.kernel.org" , "linux-input@vger.kernel.org" , "Lopez Cruz, Misael" , "linux-omap@vger.kernel.org" , "Girdwood, Liam" Subject: Re: Re: [alsa-devel] [PATCH v4 11/18] input: Add initial support for TWL6040 vibrator Date: Fri, 17 Jun 2011 12:39:57 +0300 Message-ID: <5740779.B2nyl9oMW4@barack> User-Agent: KMail/4.6.0 (Linux/2.6.39-gentoo; KDE/4.6.4; x86_64; ; ) In-Reply-To: <4306005.scnJ1lQX4P@barack> References: <1307706876-4768-1-git-send-email-peter.ujfalusi@ti.com> <20110616120244.GA2611@htj.dyndns.org> <4306005.scnJ1lQX4P@barack> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Tejun, On Thursday 16 June 2011 16:06:00 Ujfalusi, Peter wrote: > > I suppose you meant alloc_workqueue()? :) > > Oh, yes. I mean that. Just avoid another series... I have looked at the alloc_workqueue, and I'm not really sure what parameters should I use. #define create_singlethread_workqueue(name) \ alloc_workqueue((name), WQ_UNBOUND | WQ_MEM_RECLAIM, 1) I would use something like this instead of create_singlethread_workqueue: alloc_workqueue("twl6040-vibra", WQ_UNBOUND | WQ_MEM_RECLAIM | WQ_HIGHPRI, 1); Is this correct? Thanks, Péter