From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40953)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1b4XV9-0001p1-A1
	for qemu-devel@nongnu.org; Sun, 22 May 2016 13:49:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1b4XV6-0007k7-1h
	for qemu-devel@nongnu.org; Sun, 22 May 2016 13:49:19 -0400
Received: from mout.web.de ([212.227.17.11]:54612)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1b4XV5-0007jc-ON
	for qemu-devel@nongnu.org; Sun, 22 May 2016 13:49:15 -0400
References: <1463912514-12658-1-git-send-email-davidkiarie4@gmail.com>
	<1463912514-12658-2-git-send-email-davidkiarie4@gmail.com>
From: Jan Kiszka <jan.kiszka@web.de>
Message-ID: <5741F0CE.1040008@web.de>
Date: Sun, 22 May 2016 19:47:58 +0200
MIME-Version: 1.0
In-Reply-To: <1463912514-12658-2-git-send-email-davidkiarie4@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="mcifcIg4W1LWHS99GCEVlqxklcO9mQIdu"
Subject: Re: [Qemu-devel] [V11 1/4] hw/i386: Introduce AMD IOMMU
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Kiarie <davidkiarie4@gmail.com>, qemu-devel@nongnu.org
Cc: mst@redhat.com, marcel@redhat.com, peterx@redhat.com, valentine.sinitsyn@gmail.com

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--mcifcIg4W1LWHS99GCEVlqxklcO9mQIdu
From: Jan Kiszka <jan.kiszka@web.de>
To: David Kiarie <davidkiarie4@gmail.com>, qemu-devel@nongnu.org
Cc: mst@redhat.com, marcel@redhat.com, peterx@redhat.com,
 valentine.sinitsyn@gmail.com
Message-ID: <5741F0CE.1040008@web.de>
Subject: Re: [V11 1/4] hw/i386: Introduce AMD IOMMU
References: <1463912514-12658-1-git-send-email-davidkiarie4@gmail.com>
 <1463912514-12658-2-git-send-email-davidkiarie4@gmail.com>
In-Reply-To: <1463912514-12658-2-git-send-email-davidkiarie4@gmail.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: quoted-printable

On 2016-05-22 12:21, David Kiarie wrote:
> +static void amdvi_generate_msi_interrupt(AMDVIState *s)
> +{
> +    uint64_t addr;
> +    uint32_t data;
> +
> +    if ((pci_get_word(s->dev.config + s->dev.msi_cap + PCI_MSI_FLAGS) =
&
> +       PCI_MSI_FLAGS_ENABLE)) {
> +        addr =3D pci_get_quad(s->dev.config + s->dev.msi_cap +
> +                            PCI_MSI_ADDRESS_LO);
> +        data =3D pci_get_word(s->dev.config + s->dev.msi_cap +
> +                            PCI_MSI_DATA_64);

There is msi_enabled and msi_get_message - will make this a bit more
compact.

Jan



--mcifcIg4W1LWHS99GCEVlqxklcO9mQIdu
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAldB8NMACgkQitSsb3rl5xRUFwCfRwvoh7OX50/qFL8f0T/esbmq
X/YAoN5xZejgIgrMq+KblW4odIdl3Cj9
=1gZ/
-----END PGP SIGNATURE-----

--mcifcIg4W1LWHS99GCEVlqxklcO9mQIdu--