From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 2/2] dma-buf/fence: add fence_array fences v4 Date: Mon, 23 May 2016 13:29:11 +0200 Message-ID: <5742E987.3030609@vodafone.de> References: <1463752571-28688-1-git-send-email-deathsimple@vodafone.de> <1463752571-28688-2-git-send-email-deathsimple@vodafone.de> <20160520144728.GE15150@joana> <20160523074149.GW27098@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from pegasos-out.vodafone.de (pegasos-out.vodafone.de [80.84.1.38]) by gabe.freedesktop.org (Postfix) with ESMTP id 20C686E032 for ; Mon, 23 May 2016 11:29:18 +0000 (UTC) In-Reply-To: <20160523074149.GW27098@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org QW0gMjMuMDUuMjAxNiB1bSAwOTo0MSBzY2hyaWViIERhbmllbCBWZXR0ZXI6Cj4gT24gRnJpLCBN YXkgMjAsIDIwMTYgYXQgMTE6NDc6MjhBTSAtMDMwMCwgR3VzdGF2byBQYWRvdmFuIHdyb3RlOgo+ PiAyMDE2LTA1LTIwIENocmlzdGlhbiBLw7ZuaWcgPGRlYXRoc2ltcGxlQHZvZGFmb25lLmRlPjoK Pj4KPj4+IEZyb206IEd1c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2by5wYWRvdmFuQGNvbGxhYm9yYS5j by51az4KPj4+Cj4+PiBzdHJ1Y3QgZmVuY2VfY29sbGVjdGlvbiBpbmhlcml0cyBmcm9tIHN0cnVj dCBmZW5jZSBhbmQgY2FycmllcyBhCj4+PiBjb2xsZWN0aW9uIG9mIGZlbmNlcyB0aGF0IG5lZWRz IHRvIGJlIHdhaXRlZCB0b2dldGhlci4KPj4+Cj4+PiBJdCBpcyB1c2VmdWwgdG8gdHJhbnNsYXRl IGEgc3luY19maWxlIHRvIGEgZmVuY2UgdG8gcmVtb3ZlIHRoZSBjb21wbGV4aXR5Cj4+PiBvZiBk ZWFsaW5nIHdpdGggc3luY19maWxlcyBvbiBEUk0gZHJpdmVycy4gU28gZXZlbiBpZiB0aGVyZSBh cmUgbWFueQo+Pj4gZmVuY2VzIGluIHRoZSBzeW5jX2ZpbGUgdGhhdCBuZWVkcyB0byB3YWl0ZWQg Zm9yIGEgY29tbWl0IHRvIGhhcHBlbiwKPj4+IHRoZXkgYWxsIGdldCBhZGRlZCB0byB0aGUgZmVu Y2VfY29sbGVjdGlvbiBhbmQgcGFzc2VkIGZvciBEUk0gdXNlIGFzCj4+PiBhIHN0YW5kYXJkIHN0 cnVjdCBmZW5jZS4KPj4+Cj4+PiBUaGF0IG1lYW5zIHRoYXQgbm8gY2hhbmdlcyBuZWVkZWQgdG8g YW55IGRyaXZlciBiZXNpZGVzIHN1cHBvcnRpbmcgZmVuY2VzLgo+Pj4KPj4+IGZlbmNlX2NvbGxl Y3Rpb24ncyBmZW5jZSBkb2Vzbid0IGJlbG9uZyB0byBhbnkgdGltZWxpbmUgY29udGV4dCwgc28K Pj4+IGZlbmNlX2lzX2xhdGVyKCkgYW5kIGZlbmNlX2xhdGVyKCkgYXJlIG5vdCBtZWFudCB0byBi ZSBjYWxsZWQgd2l0aAo+Pj4gZmVuY2VfY29sbGVjdGlvbnMgZmVuY2VzLgo+Pj4KPj4+IHYyOiBD b21tZW50cyBieSBEYW5pZWwgVmV0dGVyOgo+Pj4gCS0gbWVyZ2UgZmVuY2VfY29sbGVjdGlvbl9p bml0KCkgYW5kIGZlbmNlX2NvbGxlY3Rpb25fYWRkKCkKPj4+IAktIG9ubHkgYWRkIGNhbGxiYWNr cyBhdCAtPmVuYWJsZV9zaWduYWxsaW5nKCkKPj4+IAktIHJlbW92ZSBmZW5jZV9jb2xsZWN0aW9u X3B1dCgpCj4+PiAJLSBjaGVjayBmb3IgdHlwZSBvbiB0b19mZW5jZV9jb2xsZWN0aW9uKCkKPj4+ IAktIGFkanVzdCBmZW5jZV9pc19sYXRlcigpIGFuZCBmZW5jZV9sYXRlcigpIHRvIFdBUk5fT04o KSBpZiB0aGV5Cj4+PiAJYXJlIHVzZWQgd2l0aCBjb2xsZWN0aW9uIGZlbmNlcy4KPj4+Cj4+PiB2 MzogLSBJbml0aWFsaXplIGZlbmNlX2NiLm5vZGUgYXQgZmVuY2UgaW5pdC4KPj4+Cj4+PiAgICAg IENvbW1lbnRzIGJ5IENocmlzIFdpbHNvbjoKPj4+IAktIHJldHVybiAidW5ib3VuZCIgb24gZmVu Y2VfY29sbGVjdGlvbl9nZXRfdGltZWxpbmVfbmFtZSgpCj4+PiAJLSBkb24ndCBzdG9wIGFkZGlu ZyBjYWxsYmFja3MgaWYgb25lIGZhaWxzCj4+PiAJLSByZW1vdmUgcmVkdW5kYW50ICEhIG9uIGZl bmNlX2NvbGxlY3Rpb25fZW5hYmxlX3NpZ25hbGluZygpCj4+PiAJLSByZW1vdmUgcmVkdW5kYW50 ICgpIG9uIGZlbmNlX2NvbGxlY3Rpb25fc2lnbmFsZWQKPj4+IAktIHVzZSBmZW5jZV9kZWZhdWx0 X3dhaXQoKSBpbnN0ZWFkCj4+Pgo+Pj4gdjQgKGNoayk6IFJld29yaywgc2ltcGxpZmljYXRpb24g YW5kIGNsZWFudXA6Cj4+PiAJLSBEcm9wIEZFTkNFX05PX0NPTlRFWFQgaGFuZGxpbmcsIGFsd2F5 cyBhbGxvY2F0ZSBhIGNvbnRleHQuCj4+PiAJLSBSZW5hbWUgdG8gZmVuY2VfYXJyYXkuCj4+PiAJ LSBSZXR1cm4gZml4ZWQgZHJpdmVyIG5hbWUuCj4+PiAJLSBSZWdpc3RlciBvbmx5IG9uZSBjYWxs YmFjayBhdCBhIHRpbWUuCj4+PiAJLSBEb2N1bWVudCB0aGF0IGNyZWF0ZSBmdW5jdGlvbiB0YWtl cyBvd25lcnNoaXAgb2YgYXJyYXkuCj4+IFRoaXMgbG9va3MgZ29vZCB0byBtZS4gRHJvcHBpbmcg Tk9fQ09OVEVYVCB3YXMgYSBnb29kIGlkZWEsIGFsc28KPj4gcmVnaXN0ZXJpbmcgb25seSBvbmUg Y2FsbGJhY2sgbWFrZXMgaXQgbG9va3MgYmV0dGVyLgo+IFRoaXMgd2lsbCBtYWtlIGl0IGV2ZW4g aGFyZGVyIHRvIGV2ZW50dWFsbHkgYWRkIGEgcmVhbCBmZW5jZV9jb250ZXh0Cj4gc3RydWN0dXJl IGZvciB0cmFja2luZyBhbmQgZGVidWdnaW5nLiBJIGtub3cgeW91IGRvbid0IGNhcmUgZm9yIGFt ZGdwdQo+IHNpbmNlIHlvdSBoYXZlIGFtZGdwdS1zcGVjaWZpYyBkZWJ1ZyBmaWxlcywgYW5kIHRo ZXJlJ3Mgc29tZSBsaWZldGltZSBmdW4KPiB0aGF0IG1ha2VzIGl0IG5vdCBpbW1lZGlhdGVseSBv YnZpb3VzIGhvdyB0byByZXNvbHZlIGl0LgoKQ29tcGxldGVseSBpbmRlcGVuZGVudCBvZiBteSB3 b3JrIG9uIGFtZGdwdSBJIHN0aWxsIHRoaW5rIHRoYXQgaXQncyBub3QgCnN1Y2ggYSBnb29kIGlk ZWEgdG8gdXNlIGEgY29tcGxleCBzdHJ1Y3R1cmUgZm9yIHRoZSBmZW5jZSBjb250ZXh0LgoKRXNw ZWNpYWxseSBvbiBTb0NzIGFuZCBzbWFsbCBlbWJlZGRlZCBzeXN0ZW1zIHlvdSBwcm9iYWJseSBk b24ndCB3YW50IHRvIApvdmVyaGVhZCBhc3NvY2lhdGVkIHdpdGggdGhhdCBvbmx5IGZvciBkZWJ1 Z2dpbmcgcHVycG9zZXMgaW4gYSAKcHJvZHVjdGlvbiBlbnZpcm9ubWVudC4KCj4gQnV0IG9uICJs b3RzIG9mCj4gc2hpdHR5IGxpdHRsZSBkcml2ZXJzIiBzeXN0ZW1zIGFrYSBTb0NzIGdlbmVyaWMg ZGVidWdnaW5nIGluZm9ybWF0aW9uIGlzCj4gY3J1Y2lhbCBJIHRoaW5rLiBOb3QgbGlraW5nIHRv byBtdWNoIHdoZXJlIHRoaXMgaXMgZ29pbmcuCgpZZWFoIEkgYWdyZWUgdGhhdCBnZW5lcmljIGRl YnVnZ2luZyBpbmZvcm1hdGlvbiBpcyB1c3VhbGx5IGNydWNpYWwsIGJ1dCAKdGhlIGxpZmV0aW1l IGlzc3VlcyBpbmRlZWQgY2FuJ3QgYmUgc29sdmVkIHdpdGhvdXQgcmVmZXJlbmNlIGNvdW50aW5n IAphbmQgYSBob2xlIGJ1bmNoIG9mIG92ZXJoZWFkLgoKSG93IGFib3V0IFY1IG9mIHRoZSBwYXRj aCBJJ3ZlIGp1c3Qgc2VuZCBvdXQ/IEFwYXJ0IGZyb20gZml4aW5nIGEgZmV3IAppc3N1ZXMgSSd2 ZSBtYWRlIHRoZSBjb250ZXh0IGFuZCBzZXF1ZW5jZSBudW1iZXIgcGFyYW1ldGVycyBvZiB0aGUg CmZlbmNlX2FycmF5IG9iamVjdC4KClRoaXMgd2F5IHlvdSBkb24ndCBuZWVkIHRvIGFsd2F5cyBh bGxvY2F0ZSBhIG5ldyBjb250ZXh0IGZvciBlYWNoIApvYmplY3QsIGJ1dCBqdXN0IGVub3VnaCB0 byBrZWVwIHlvdXIgdGltZWxpbmVzIHN0cmFpZ2h0LgoKRS5nLiB5b3UgZG9uJ3QgZ2V0IGEgbG90 IG9mIGNvbnRleHRzIG9ubHkgdXNlZCBvbmNlLiBUaGlzIGlzIGF0IGxlYXN0IApzdWZmaWNpZW50 IGZvciBteSBhbWRncHUgdXNlIGNhc2UuCgpSZWdhcmRzLApDaHJpc3RpYW4uCgo+IC1EYW5pZWwK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZl bCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754783AbcEWL3V (ORCPT ); Mon, 23 May 2016 07:29:21 -0400 Received: from pegasos-out.vodafone.de ([80.84.1.38]:52061 "EHLO pegasos-out.vodafone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752707AbcEWL3T (ORCPT ); Mon, 23 May 2016 07:29:19 -0400 X-Spam-Flag: NO X-Spam-Score: -0.045 Authentication-Results: rohrpostix1.prod.vfnet.de (amavisd-new); dkim=pass header.i=@vodafone.de X-DKIM: OpenDKIM Filter v2.6.8 pegasos-out.vodafone.de 856FB261A6C Subject: Re: [PATCH 2/2] dma-buf/fence: add fence_array fences v4 To: Gustavo Padovan , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <1463752571-28688-1-git-send-email-deathsimple@vodafone.de> <1463752571-28688-2-git-send-email-deathsimple@vodafone.de> <20160520144728.GE15150@joana> <20160523074149.GW27098@phenom.ffwll.local> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <5742E987.3030609@vodafone.de> Date: Mon, 23 May 2016 13:29:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160523074149.GW27098@phenom.ffwll.local> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 23.05.2016 um 09:41 schrieb Daniel Vetter: > On Fri, May 20, 2016 at 11:47:28AM -0300, Gustavo Padovan wrote: >> 2016-05-20 Christian König : >> >>> From: Gustavo Padovan >>> >>> struct fence_collection inherits from struct fence and carries a >>> collection of fences that needs to be waited together. >>> >>> It is useful to translate a sync_file to a fence to remove the complexity >>> of dealing with sync_files on DRM drivers. So even if there are many >>> fences in the sync_file that needs to waited for a commit to happen, >>> they all get added to the fence_collection and passed for DRM use as >>> a standard struct fence. >>> >>> That means that no changes needed to any driver besides supporting fences. >>> >>> fence_collection's fence doesn't belong to any timeline context, so >>> fence_is_later() and fence_later() are not meant to be called with >>> fence_collections fences. >>> >>> v2: Comments by Daniel Vetter: >>> - merge fence_collection_init() and fence_collection_add() >>> - only add callbacks at ->enable_signalling() >>> - remove fence_collection_put() >>> - check for type on to_fence_collection() >>> - adjust fence_is_later() and fence_later() to WARN_ON() if they >>> are used with collection fences. >>> >>> v3: - Initialize fence_cb.node at fence init. >>> >>> Comments by Chris Wilson: >>> - return "unbound" on fence_collection_get_timeline_name() >>> - don't stop adding callbacks if one fails >>> - remove redundant !! on fence_collection_enable_signaling() >>> - remove redundant () on fence_collection_signaled >>> - use fence_default_wait() instead >>> >>> v4 (chk): Rework, simplification and cleanup: >>> - Drop FENCE_NO_CONTEXT handling, always allocate a context. >>> - Rename to fence_array. >>> - Return fixed driver name. >>> - Register only one callback at a time. >>> - Document that create function takes ownership of array. >> This looks good to me. Dropping NO_CONTEXT was a good idea, also >> registering only one callback makes it looks better. > This will make it even harder to eventually add a real fence_context > structure for tracking and debugging. I know you don't care for amdgpu > since you have amdgpu-specific debug files, and there's some lifetime fun > that makes it not immediately obvious how to resolve it. Completely independent of my work on amdgpu I still think that it's not such a good idea to use a complex structure for the fence context. Especially on SoCs and small embedded systems you probably don't want to overhead associated with that only for debugging purposes in a production environment. > But on "lots of > shitty little drivers" systems aka SoCs generic debugging information is > crucial I think. Not liking too much where this is going. Yeah I agree that generic debugging information is usually crucial, but the lifetime issues indeed can't be solved without reference counting and a hole bunch of overhead. How about V5 of the patch I've just send out? Apart from fixing a few issues I've made the context and sequence number parameters of the fence_array object. This way you don't need to always allocate a new context for each object, but just enough to keep your timelines straight. E.g. you don't get a lot of contexts only used once. This is at least sufficient for my amdgpu use case. Regards, Christian. > -Daniel