From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52296) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4sK5-00044E-Ck for qemu-devel@nongnu.org; Mon, 23 May 2016 12:03:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b4sK3-0002HP-AM for qemu-devel@nongnu.org; Mon, 23 May 2016 12:03:16 -0400 References: <1462552005-4887-1-git-send-email-eblake@redhat.com> <1462552005-4887-4-git-send-email-eblake@redhat.com> <20160523154206.GD4951@noname.redhat.com> From: Eric Blake Message-ID: <574329BB.8050301@redhat.com> Date: Mon, 23 May 2016 10:03:07 -0600 MIME-Version: 1.0 In-Reply-To: <20160523154206.GD4951@noname.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AjW1EQLlrndoShVi7AUx7XlGIQGs852b3" Subject: Re: [Qemu-devel] [PATCH v7 03/19] block: Switch blk_*write_zeroes() to byte interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz , Stefan Hajnoczi , "Denis V. Lunev" , Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --AjW1EQLlrndoShVi7AUx7XlGIQGs852b3 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/23/2016 09:42 AM, Kevin Wolf wrote: > Am 06.05.2016 um 18:26 hat Eric Blake geschrieben: >> Sector-based blk_write() should die; convert the one-off >> variant blk_write_zeroes() to use an offset/count interface >> instead. Likewise for blk_co_write_zeroes() and >> blk_aio_write_zeroes(). >> >> Signed-off-by: Eric Blake >=20 > You built a nice trap here: bdrv_*write_zeroes() is still sector based > whereas blk_*write_zeroes() changed to be byte based without a rename. > That broke my block jobs series which converts from bdrv_* to blk_* > after the next (seemingly clean) rebase. >=20 > I fixed my series now, but can we please convert bdrv_* as well > before we get more victims in the same trap? Also (and perhaps more > importantly) we could rename the functions to something like > blk_*pwrite_zeroes(), indicating the switch to byte based. Sure, the rename idea makes sense. I should have something posted later today. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --AjW1EQLlrndoShVi7AUx7XlGIQGs852b3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXQym8AAoJEKeha0olJ0Nq9zMH/3my7dhbX8Ya5cAmrs2hapkH R6dZLoCK3pGa7QZj3pnxP35MOUAxxDZv7xbGPAAmGB6adlnVsWA8jqfxF0IeC/cM 1OtVVQ7E8vkL4GrOsGP+iDeuXXSvBb62K15km9FE6tkw9+C6CyUfhyQ9v9z+AXw1 MIc59X4uICjo0ytsh/is7Lc7ZF/EgRybJxwO/yzSenoebTqXl6KykklQ0FUi5vKF oiUBF8xtb0e9XTzdOLh2c4tJ924c02CmX1mOCMi2UtcF1FXkEtPaPttf/cZBeVXa 8Wod5EbmOvdyjod7fcW+5pgRKX2dlzTb0TVvzOUi1SLwWEzNciuzBnN04vIDF7c= =EaH+ -----END PGP SIGNATURE----- --AjW1EQLlrndoShVi7AUx7XlGIQGs852b3--