From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4vTl-0003KX-Ly for qemu-devel@nongnu.org; Mon, 23 May 2016 15:25:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b4vTf-00050r-JS for qemu-devel@nongnu.org; Mon, 23 May 2016 15:25:28 -0400 Received: from mail-oi0-x235.google.com ([2607:f8b0:4003:c06::235]:35354) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4vTf-00050g-EF for qemu-devel@nongnu.org; Mon, 23 May 2016 15:25:23 -0400 Received: by mail-oi0-x235.google.com with SMTP id x19so293940822oix.2 for ; Mon, 23 May 2016 12:25:23 -0700 (PDT) References: <1463671442-15631-1-git-send-email-minyard@acm.org> <1463671442-15631-6-git-send-email-minyard@acm.org> <20160520115344.29b1a24d@nial.brq.redhat.com> From: Corey Minyard Message-ID: <57435921.1090909@mvista.com> Date: Mon, 23 May 2016 14:25:21 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 5/6] acpi: Add IPMI table entries List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Igor Mammedov , minyard@acm.org Cc: "Michael S . Tsirkin" , qemu-devel@nongnu.org On 05/23/2016 01:06 PM, Paolo Bonzini wrote: > > On 20/05/2016 11:53, Igor Mammedov wrote: >>>> diff --git a/hw/acpi/noipmi.c b/hw/acpi/noipmi.c >>>> new file mode 100644 >>>> index 0000000..dd7590d >>>> --- /dev/null >>>> +++ b/hw/acpi/noipmi.c >> move this to .a/stubs/ >> > Don't overuse stubs. The stubs library is mostly to share code between > QEMU and the tools. What Corey did is more similar to what hw/ already > does in other places. Should I change it back? > Unfortunately, weak symbols are not portable. :( Yeah, that's really a pain. -corey > Paolo