Re: [PATCH] net/idpf: fix build option check

[Thomas Monjalon <thomas@monjalon.net>]

13/12/2022 02:52, Zhang, Qi Z:
> From: Xing, Beilei <beilei.xing@intel.com>
> > From: Wu, Jingjing <jingjing.wu@intel.com>
> > > When enable_iova_as_pa option is disabled, idpf driver should avoid
> > > the building in its build file.
> > >
> > > Fixes: 5bf87b45b2c8 (net/idpf: add AVX512 data path for single queue
> > > model)
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> > > ---
> > > --- a/drivers/net/idpf/meson.build
> > > +++ b/drivers/net/idpf/meson.build
> > > +if dpdk_conf.get('RTE_IOVA_AS_PA') == 0
> > > +    build = false
> > > +    reason = 'driver does not support disabling IOVA as PA mode'
> > > +    subdir_done()
> > > +endif
> > 
> > Acked-by: Beilei Xing <beilei.xing@intel.com>
> 
> Applied to dpdk-next-net-intel.

I think this patch is not needed since we have this check done for all drivers:

+        pmd_supports_disable_iova_as_pa = false
[...]
+            if dpdk_conf.get('RTE_IOVA_AS_PA') == 0 and not pmd_supports_disable_iova_as_pa and not always_enable.contains(drv_path)
+                build = false
+                reason = 'driver does not support disabling IOVA as PA mode'
+            endif

I will skip this patch and mark it as Rejected in patchwork.
Please confirm the decision is OK.