All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: ath10k <ath10k@lists.infradead.org>
Subject: Memory leak under certain loads.
Date: Mon, 23 May 2016 17:19:28 -0700	[thread overview]
Message-ID: <57439E10.4040106@candelatech.com> (raw)

I spent the day looking for memory leaks, and made little progress.

I'm posting this in case someone has a suggestion.

Kernel is 4.4.10+, lots of local patches, and probably ath10k driver is close to
4.4.6 code (it has wave-2 10.4.3 firmware support, for instance).

I modified mac80211 to limit the backlog queue in the method below, so it should
not be this.

static bool ieee80211_tx_frags(struct ieee80211_local *local,
			       struct ieee80211_vif *vif,
			       struct ieee80211_sta *sta,
			       struct sk_buff_head *skbs,
			       bool txpending)

and, fixed pktgen to not crash on skb overrun when used on wlanX


ath10k Firmware is CT firmware.


I start pktgen trying to send 100kpps from station device to another AP
device.

ath9k:  No problems
ath10k-wave1:  Appears to be fairly fast memory leak.  Memory is not reclaimed when
     pktgen is stopped.
ath10k-wave2:  Consumes lots of memory (4G and rising after 20-30 seconds), but at least most comes
     back when pktgen is stopped.  This very much looks like there are lots of pkts buffered somewhere.

In all cases, if I use 'kmemleak', system runs a lot slower (tries to send around 35kpps instead of 99kpps),
and I detect no excessive memory usage as seen with 'top', nor does kmemleak find anything that looks related
to this.

Perhaps related, an OpenWRT variant reports OOM bugs with ath10k wave-1 systems too,
but seems their instability is on the order of 1-2 days between crashes.  They suspect
this came down with a recent backport, but I did not dig into exactly what they have.


https://github.com/freifunk-gluon/gluon/issues/690

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

                 reply	other threads:[~2016-05-24  0:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57439E10.4040106@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=ath10k@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.