From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Hsu Subject: Re: [PATCH 1/2 v2] ASoC: nau8825: non-clock jack detection for power saving at standby Date: Tue, 24 May 2016 11:41:02 +0800 Message-ID: <5743CD4E.6020805@nuvoton.com> References: <1463131037-19220-1-git-send-email-KCHSU0@nuvoton.com> <20160513104841.GA22038@sirena.org.uk> <573926C5.70704@nuvoton.com> <20160518170549.GR8104@sirena.org.uk> <573E80A7.50602@nuvoton.com> <20160520110137.GJ8206@sirena.org.uk> <5742641A.9070409@nuvoton.com> <20160523170432.GA8206@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from maillog.nuvoton.com (maillog.nuvoton.com [202.39.227.15]) by alsa0.perex.cz (Postfix) with ESMTP id 8F182260568 for ; Tue, 24 May 2016 05:41:06 +0200 (CEST) In-Reply-To: <20160523170432.GA8206@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: AP MS30 Linux ALSA , "anatol.pomozov@gmail.com" , AC30 YHChuang , "lgirdwood@gmail.com" , "benzh@chromium.org" , AC30 CTLin0 , MS40 MHKuo , "yong.zhi@intel.com" List-Id: alsa-devel@alsa-project.org Hi, On 5/24/2016 1:04 AM, Mark Brown wrote: > On Mon, May 23, 2016 at 09:59:54AM +0800, John Hsu wrote: > >> On 5/20/2016 7:01 PM, Mark Brown wrote: >> > > >>> I understand what it's doing but obviously a biquad filter isn't >>> specialized for this function... >>> > > >> Yes, the biquad filter is general purpose feature. Could you give us >> suggestion about how to implement the biquad filter for common fea- >> ture and to fix DC offset as well? >> > > The trouble is you'd have to do the configuration in userspace or do > something like only do the DC offset correction if no other filter is > configured. TBH it's not unreasonable to suggest people should just > configured a high pass filter if they're having issues, though it's a > bit more work :( > Is it acceptable if we change our patch to do the DC offset correction instead of general BIQ filter for the issue?